Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: explicitly declare used dependencies #6670

Closed
wants to merge 1 commit into from
Closed

chore: explicitly declare used dependencies #6670

wants to merge 1 commit into from

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Apr 15, 2024

Motivation

List all dependencies used by projects. yargs is used in utils, but not defined in the associated package.json.

@jeluard jeluard requested a review from a team as a code owner April 15, 2024 06:57
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #6670 (985ac59) into unstable (ae984f0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6670   +/-   ##
=========================================
  Coverage     61.81%   61.81%           
=========================================
  Files           556      556           
  Lines         59050    59050           
  Branches       1898     1898           
=========================================
  Hits          36502    36502           
  Misses        22505    22505           
  Partials         43       43

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8a687e3 Previous: ae984f0 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 858.70 us/op 679.83 us/op 1.26
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 80.788 us/op 107.00 us/op 0.76
BLS verify - blst-native 1.2920 ms/op 1.3826 ms/op 0.93
BLS verifyMultipleSignatures 3 - blst-native 2.7116 ms/op 2.8539 ms/op 0.95
BLS verifyMultipleSignatures 8 - blst-native 5.9477 ms/op 6.2462 ms/op 0.95
BLS verifyMultipleSignatures 32 - blst-native 21.780 ms/op 22.893 ms/op 0.95
BLS verifyMultipleSignatures 64 - blst-native 42.892 ms/op 46.461 ms/op 0.92
BLS verifyMultipleSignatures 128 - blst-native 85.721 ms/op 94.462 ms/op 0.91
BLS deserializing 10000 signatures 923.58 ms/op 968.93 ms/op 0.95
BLS deserializing 100000 signatures 9.2033 s/op 8.9732 s/op 1.03
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.4875 ms/op 1.3743 ms/op 1.08
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4603 ms/op 1.5601 ms/op 0.94
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.2483 ms/op 2.3996 ms/op 0.94
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.8011 ms/op 3.4012 ms/op 1.41
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.5978 ms/op 5.7714 ms/op 0.97
BLS aggregatePubkeys 32 - blst-native 26.242 us/op 26.284 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 100.31 us/op 100.33 us/op 1.00
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 61.661 ms/op 64.205 ms/op 0.96
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 56.268 ms/op 59.169 ms/op 0.95
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 33.932 ms/op 53.250 ms/op 0.64
getSlashingsAndExits - default max 164.47 us/op 207.45 us/op 0.79
getSlashingsAndExits - 2k 581.50 us/op 597.64 us/op 0.97
proposeBlockBody type=full, size=empty 5.3255 ms/op 8.0017 ms/op 0.67
isKnown best case - 1 super set check 293.00 ns/op 740.00 ns/op 0.40
isKnown normal case - 2 super set checks 304.00 ns/op 739.00 ns/op 0.41
isKnown worse case - 16 super set checks 300.00 ns/op 649.00 ns/op 0.46
InMemoryCheckpointStateCache - add get delete 5.4840 us/op 8.7280 us/op 0.63
validate api signedAggregateAndProof - struct 2.6941 ms/op 3.0190 ms/op 0.89
validate gossip signedAggregateAndProof - struct 2.6910 ms/op 2.9503 ms/op 0.91
validate gossip attestation - vc 640000 1.3266 ms/op 1.4169 ms/op 0.94
batch validate gossip attestation - vc 640000 - chunk 32 158.04 us/op 169.53 us/op 0.93
batch validate gossip attestation - vc 640000 - chunk 64 142.68 us/op 148.73 us/op 0.96
batch validate gossip attestation - vc 640000 - chunk 128 140.99 us/op 139.53 us/op 1.01
batch validate gossip attestation - vc 640000 - chunk 256 133.57 us/op 127.81 us/op 1.05
pickEth1Vote - no votes 1.3915 ms/op 1.1556 ms/op 1.20
pickEth1Vote - max votes 9.2614 ms/op 9.1164 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.856 ms/op 15.981 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 28.185 ms/op 24.409 ms/op 1.15
pickEth1Vote - Eth1Data fastSerialize value x2048 743.46 us/op 597.39 us/op 1.24
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.3581 ms/op 4.2496 ms/op 1.50
bytes32 toHexString 847.00 ns/op 481.00 ns/op 1.76
bytes32 Buffer.toString(hex) 335.00 ns/op 284.00 ns/op 1.18
bytes32 Buffer.toString(hex) from Uint8Array 617.00 ns/op 411.00 ns/op 1.50
bytes32 Buffer.toString(hex) + 0x 355.00 ns/op 288.00 ns/op 1.23
Object access 1 prop 0.26200 ns/op 0.15900 ns/op 1.65
Map access 1 prop 0.16900 ns/op 0.14800 ns/op 1.14
Object get x1000 8.3770 ns/op 7.2450 ns/op 1.16
Map get x1000 0.96000 ns/op 0.73400 ns/op 1.31
Object set x1000 81.195 ns/op 48.062 ns/op 1.69
Map set x1000 60.892 ns/op 38.120 ns/op 1.60
Return object 10000 times 0.26980 ns/op 0.23690 ns/op 1.14
Throw Error 10000 times 4.1656 us/op 3.8225 us/op 1.09
fastMsgIdFn sha256 / 200 bytes 3.6110 us/op 3.2360 us/op 1.12
fastMsgIdFn h32 xxhash / 200 bytes 386.00 ns/op 277.00 ns/op 1.39
fastMsgIdFn h64 xxhash / 200 bytes 425.00 ns/op 345.00 ns/op 1.23
fastMsgIdFn sha256 / 1000 bytes 12.029 us/op 11.231 us/op 1.07
fastMsgIdFn h32 xxhash / 1000 bytes 471.00 ns/op 395.00 ns/op 1.19
fastMsgIdFn h64 xxhash / 1000 bytes 495.00 ns/op 413.00 ns/op 1.20
fastMsgIdFn sha256 / 10000 bytes 105.41 us/op 102.94 us/op 1.02
fastMsgIdFn h32 xxhash / 10000 bytes 2.0200 us/op 1.8900 us/op 1.07
fastMsgIdFn h64 xxhash / 10000 bytes 1.4210 us/op 1.2900 us/op 1.10
send data - 1000 256B messages 21.452 ms/op 18.299 ms/op 1.17
send data - 1000 512B messages 24.802 ms/op 25.403 ms/op 0.98
send data - 1000 1024B messages 46.030 ms/op 39.722 ms/op 1.16
send data - 1000 1200B messages 41.049 ms/op 40.113 ms/op 1.02
send data - 1000 2048B messages 48.646 ms/op 50.297 ms/op 0.97
send data - 1000 4096B messages 43.033 ms/op 44.953 ms/op 0.96
send data - 1000 16384B messages 116.73 ms/op 120.57 ms/op 0.97
send data - 1000 65536B messages 497.16 ms/op 460.66 ms/op 1.08
enrSubnets - fastDeserialize 64 bits 1.2510 us/op 1.2750 us/op 0.98
enrSubnets - ssz BitVector 64 bits 427.00 ns/op 432.00 ns/op 0.99
enrSubnets - fastDeserialize 4 bits 165.00 ns/op 175.00 ns/op 0.94
enrSubnets - ssz BitVector 4 bits 447.00 ns/op 437.00 ns/op 1.02
prioritizePeers score -10:0 att 32-0.1 sync 2-0 209.78 us/op 217.84 us/op 0.96
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 264.78 us/op 273.90 us/op 0.97
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 325.42 us/op 342.17 us/op 0.95
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 559.16 us/op 594.39 us/op 0.94
prioritizePeers score 0:0 att 64-1 sync 4-1 689.98 us/op 730.03 us/op 0.95
array of 16000 items push then shift 1.6119 us/op 1.6575 us/op 0.97
LinkedList of 16000 items push then shift 8.9230 ns/op 9.0870 ns/op 0.98
array of 16000 items push then pop 77.935 ns/op 87.564 ns/op 0.89
LinkedList of 16000 items push then pop 8.8610 ns/op 8.8930 ns/op 1.00
array of 24000 items push then shift 2.4145 us/op 2.4132 us/op 1.00
LinkedList of 24000 items push then shift 9.0750 ns/op 9.0720 ns/op 1.00
array of 24000 items push then pop 109.04 ns/op 120.35 ns/op 0.91
LinkedList of 24000 items push then pop 8.9170 ns/op 8.8380 ns/op 1.01
intersect bitArray bitLen 8 5.9940 ns/op 5.9310 ns/op 1.01
intersect array and set length 8 69.712 ns/op 65.118 ns/op 1.07
intersect bitArray bitLen 128 36.185 ns/op 36.181 ns/op 1.00
intersect array and set length 128 893.54 ns/op 904.72 ns/op 0.99
bitArray.getTrueBitIndexes() bitLen 128 1.4740 us/op 1.6080 us/op 0.92
bitArray.getTrueBitIndexes() bitLen 248 2.9840 us/op 2.6890 us/op 1.11
bitArray.getTrueBitIndexes() bitLen 512 5.5190 us/op 5.2060 us/op 1.06
Buffer.concat 32 items 1.0490 us/op 1.1760 us/op 0.89
Uint8Array.set 32 items 1.8560 us/op 1.9210 us/op 0.97
Set add up to 64 items then delete first 4.8267 us/op 4.3733 us/op 1.10
OrderedSet add up to 64 items then delete first 5.9747 us/op 5.5538 us/op 1.08
Set add up to 64 items then delete last 4.8265 us/op 4.6900 us/op 1.03
OrderedSet add up to 64 items then delete last 6.2121 us/op 5.8771 us/op 1.06
Set add up to 64 items then delete middle 4.7240 us/op 4.8264 us/op 0.98
OrderedSet add up to 64 items then delete middle 7.4501 us/op 7.1851 us/op 1.04
Set add up to 128 items then delete first 9.6809 us/op 9.6574 us/op 1.00
OrderedSet add up to 128 items then delete first 12.330 us/op 13.130 us/op 0.94
Set add up to 128 items then delete last 9.6160 us/op 9.5139 us/op 1.01
OrderedSet add up to 128 items then delete last 12.681 us/op 11.967 us/op 1.06
Set add up to 128 items then delete middle 9.6609 us/op 9.3372 us/op 1.03
OrderedSet add up to 128 items then delete middle 17.940 us/op 17.978 us/op 1.00
Set add up to 256 items then delete first 19.559 us/op 19.790 us/op 0.99
OrderedSet add up to 256 items then delete first 23.912 us/op 28.492 us/op 0.84
Set add up to 256 items then delete last 18.724 us/op 19.309 us/op 0.97
OrderedSet add up to 256 items then delete last 24.887 us/op 24.277 us/op 1.03
Set add up to 256 items then delete middle 18.422 us/op 19.030 us/op 0.97
OrderedSet add up to 256 items then delete middle 45.946 us/op 47.200 us/op 0.97
transfer serialized Status (84 B) 1.8330 us/op 1.7500 us/op 1.05
copy serialized Status (84 B) 1.3640 us/op 1.3280 us/op 1.03
transfer serialized SignedVoluntaryExit (112 B) 1.8850 us/op 1.9950 us/op 0.94
copy serialized SignedVoluntaryExit (112 B) 1.5050 us/op 1.6570 us/op 0.91
transfer serialized ProposerSlashing (416 B) 1.9970 us/op 3.2420 us/op 0.62
copy serialized ProposerSlashing (416 B) 1.5990 us/op 2.9820 us/op 0.54
transfer serialized Attestation (485 B) 1.9030 us/op 3.4460 us/op 0.55
copy serialized Attestation (485 B) 1.6730 us/op 3.1520 us/op 0.53
transfer serialized AttesterSlashing (33232 B) 2.0290 us/op 3.3010 us/op 0.61
copy serialized AttesterSlashing (33232 B) 4.8660 us/op 6.4470 us/op 0.75
transfer serialized Small SignedBeaconBlock (128000 B) 2.3600 us/op 3.4130 us/op 0.69
copy serialized Small SignedBeaconBlock (128000 B) 17.040 us/op 16.319 us/op 1.04
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8680 us/op 3.7740 us/op 0.76
copy serialized Avg SignedBeaconBlock (200000 B) 20.216 us/op 23.907 us/op 0.85
transfer serialized BlobsSidecar (524380 B) 2.7690 us/op 3.8790 us/op 0.71
copy serialized BlobsSidecar (524380 B) 109.27 us/op 189.82 us/op 0.58
transfer serialized Big SignedBeaconBlock (1000000 B) 2.7210 us/op 4.0430 us/op 0.67
copy serialized Big SignedBeaconBlock (1000000 B) 152.53 us/op 159.69 us/op 0.96
pass gossip attestations to forkchoice per slot 3.7784 ms/op 4.6671 ms/op 0.81
forkChoice updateHead vc 100000 bc 64 eq 0 685.78 us/op 700.41 us/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 0 4.2741 ms/op 5.0507 ms/op 0.85
forkChoice updateHead vc 1000000 bc 64 eq 0 7.0167 ms/op 7.3799 ms/op 0.95
forkChoice updateHead vc 600000 bc 320 eq 0 4.1991 ms/op 4.3554 ms/op 0.96
forkChoice updateHead vc 600000 bc 1200 eq 0 4.2599 ms/op 4.4869 ms/op 0.95
forkChoice updateHead vc 600000 bc 7200 eq 0 5.3703 ms/op 5.9469 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 1000 11.169 ms/op 11.548 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 10000 11.862 ms/op 12.239 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 300000 16.134 ms/op 16.697 ms/op 0.97
computeDeltas 500000 validators 300 proto nodes 6.6482 ms/op 7.0034 ms/op 0.95
computeDeltas 500000 validators 1200 proto nodes 6.6262 ms/op 6.9346 ms/op 0.96
computeDeltas 500000 validators 7200 proto nodes 6.4427 ms/op 6.5988 ms/op 0.98
computeDeltas 750000 validators 300 proto nodes 9.7793 ms/op 10.166 ms/op 0.96
computeDeltas 750000 validators 1200 proto nodes 9.7650 ms/op 10.070 ms/op 0.97
computeDeltas 750000 validators 7200 proto nodes 9.8206 ms/op 10.077 ms/op 0.97
computeDeltas 1400000 validators 300 proto nodes 18.666 ms/op 19.209 ms/op 0.97
computeDeltas 1400000 validators 1200 proto nodes 18.883 ms/op 19.126 ms/op 0.99
computeDeltas 1400000 validators 7200 proto nodes 18.637 ms/op 19.163 ms/op 0.97
computeDeltas 2100000 validators 300 proto nodes 27.311 ms/op 28.235 ms/op 0.97
computeDeltas 2100000 validators 1200 proto nodes 27.100 ms/op 27.520 ms/op 0.98
computeDeltas 2100000 validators 7200 proto nodes 27.856 ms/op 28.962 ms/op 0.96
altair processAttestation - 250000 vs - 7PWei normalcase 2.3300 ms/op 2.7419 ms/op 0.85
altair processAttestation - 250000 vs - 7PWei worstcase 3.4592 ms/op 4.1149 ms/op 0.84
altair processAttestation - setStatus - 1/6 committees join 195.20 us/op 206.03 us/op 0.95
altair processAttestation - setStatus - 1/3 committees join 359.66 us/op 375.34 us/op 0.96
altair processAttestation - setStatus - 1/2 committees join 474.82 us/op 522.27 us/op 0.91
altair processAttestation - setStatus - 2/3 committees join 602.34 us/op 672.60 us/op 0.90
altair processAttestation - setStatus - 4/5 committees join 816.53 us/op 885.73 us/op 0.92
altair processAttestation - setStatus - 100% committees join 925.08 us/op 1.0630 ms/op 0.87
altair processBlock - 250000 vs - 7PWei normalcase 8.5992 ms/op 9.4320 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.486 ms/op 40.689 ms/op 0.85
altair processBlock - 250000 vs - 7PWei worstcase 48.024 ms/op 55.116 ms/op 0.87
altair processBlock - 250000 vs - 7PWei worstcase hashState 94.106 ms/op 126.97 ms/op 0.74
phase0 processBlock - 250000 vs - 7PWei normalcase 2.6928 ms/op 4.1865 ms/op 0.64
phase0 processBlock - 250000 vs - 7PWei worstcase 32.229 ms/op 38.385 ms/op 0.84
altair processEth1Data - 250000 vs - 7PWei normalcase 510.46 us/op 803.69 us/op 0.64
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 13.159 us/op 26.507 us/op 0.50
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 70.406 us/op 88.056 us/op 0.80
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 30.192 us/op 32.963 us/op 0.92
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 16.517 us/op 24.755 us/op 0.67
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 209.25 us/op 240.26 us/op 0.87
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.2840 ms/op 1.8372 ms/op 0.70
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.7292 ms/op 2.7300 ms/op 0.63
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.8709 ms/op 2.6109 ms/op 0.72
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.2918 ms/op 5.2719 ms/op 0.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.6825 ms/op 3.5065 ms/op 0.77
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.5648 ms/op 7.4469 ms/op 0.88
Tree 40 250000 create 368.24 ms/op 782.38 ms/op 0.47
Tree 40 250000 get(125000) 213.49 ns/op 260.80 ns/op 0.82
Tree 40 250000 set(125000) 1.0710 us/op 3.2939 us/op 0.33
Tree 40 250000 toArray() 22.467 ms/op 33.072 ms/op 0.68
Tree 40 250000 iterate all - toArray() + loop 20.938 ms/op 32.464 ms/op 0.64
Tree 40 250000 iterate all - get(i) 77.698 ms/op 87.995 ms/op 0.88
MutableVector 250000 create 18.312 ms/op 19.581 ms/op 0.94
MutableVector 250000 get(125000) 7.0660 ns/op 7.7060 ns/op 0.92
MutableVector 250000 set(125000) 310.58 ns/op 690.85 ns/op 0.45
MutableVector 250000 toArray() 3.9462 ms/op 5.3295 ms/op 0.74
MutableVector 250000 iterate all - toArray() + loop 4.1649 ms/op 5.5741 ms/op 0.75
MutableVector 250000 iterate all - get(i) 1.6344 ms/op 1.6992 ms/op 0.96
Array 250000 create 3.8018 ms/op 4.4676 ms/op 0.85
Array 250000 clone - spread 1.4189 ms/op 1.8013 ms/op 0.79
Array 250000 get(125000) 1.2640 ns/op 1.4220 ns/op 0.89
Array 250000 set(125000) 5.4870 ns/op 6.0350 ns/op 0.91
Array 250000 iterate all - loop 175.55 us/op 192.60 us/op 0.91
effectiveBalanceIncrements clone Uint8Array 300000 43.952 us/op 69.487 us/op 0.63
effectiveBalanceIncrements clone MutableVector 300000 432.00 ns/op 540.00 ns/op 0.80
effectiveBalanceIncrements rw all Uint8Array 300000 221.21 us/op 225.03 us/op 0.98
effectiveBalanceIncrements rw all MutableVector 300000 121.11 ms/op 161.94 ms/op 0.75
phase0 afterProcessEpoch - 250000 vs - 7PWei 123.50 ms/op 138.33 ms/op 0.89
phase0 beforeProcessEpoch - 250000 vs - 7PWei 62.144 ms/op 51.168 ms/op 1.21
altair processEpoch - mainnet_e81889 644.55 ms/op 600.59 ms/op 1.07
mainnet_e81889 - altair beforeProcessEpoch 126.32 ms/op 101.39 ms/op 1.25
mainnet_e81889 - altair processJustificationAndFinalization 28.682 us/op 17.748 us/op 1.62
mainnet_e81889 - altair processInactivityUpdates 10.283 ms/op 8.5947 ms/op 1.20
mainnet_e81889 - altair processRewardsAndPenalties 85.633 ms/op 66.367 ms/op 1.29
mainnet_e81889 - altair processRegistryUpdates 3.4170 us/op 2.8010 us/op 1.22
mainnet_e81889 - altair processSlashings 712.00 ns/op 502.00 ns/op 1.42
mainnet_e81889 - altair processEth1DataReset 1.0710 us/op 818.00 ns/op 1.31
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.4359 ms/op 1.6723 ms/op 0.86
mainnet_e81889 - altair processSlashingsReset 3.4800 us/op 4.9530 us/op 0.70
mainnet_e81889 - altair processRandaoMixesReset 5.5970 us/op 8.5010 us/op 0.66
mainnet_e81889 - altair processHistoricalRootsUpdate 911.00 ns/op 1.2940 us/op 0.70
mainnet_e81889 - altair processParticipationFlagUpdates 4.0780 us/op 3.7510 us/op 1.09
mainnet_e81889 - altair processSyncCommitteeUpdates 839.00 ns/op 924.00 ns/op 0.91
mainnet_e81889 - altair afterProcessEpoch 125.88 ms/op 131.21 ms/op 0.96
capella processEpoch - mainnet_e217614 2.1121 s/op 3.5070 s/op 0.60
mainnet_e217614 - capella beforeProcessEpoch 502.38 ms/op 750.51 ms/op 0.67
mainnet_e217614 - capella processJustificationAndFinalization 15.335 us/op 35.132 us/op 0.44
mainnet_e217614 - capella processInactivityUpdates 19.239 ms/op 33.453 ms/op 0.58
mainnet_e217614 - capella processRewardsAndPenalties 502.64 ms/op 799.51 ms/op 0.63
mainnet_e217614 - capella processRegistryUpdates 25.626 us/op 46.184 us/op 0.55
mainnet_e217614 - capella processSlashings 452.00 ns/op 1.7450 us/op 0.26
mainnet_e217614 - capella processEth1DataReset 413.00 ns/op 2.1040 us/op 0.20
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.4569 ms/op 7.2041 ms/op 0.62
mainnet_e217614 - capella processSlashingsReset 3.1000 us/op 9.3440 us/op 0.33
mainnet_e217614 - capella processRandaoMixesReset 4.7070 us/op 15.891 us/op 0.30
mainnet_e217614 - capella processHistoricalRootsUpdate 511.00 ns/op 1.8200 us/op 0.28
mainnet_e217614 - capella processParticipationFlagUpdates 1.4630 us/op 5.8550 us/op 0.25
mainnet_e217614 - capella afterProcessEpoch 312.15 ms/op 427.01 ms/op 0.73
phase0 processEpoch - mainnet_e58758 476.41 ms/op 714.70 ms/op 0.67
mainnet_e58758 - phase0 beforeProcessEpoch 155.23 ms/op 191.59 ms/op 0.81
mainnet_e58758 - phase0 processJustificationAndFinalization 17.291 us/op 33.445 us/op 0.52
mainnet_e58758 - phase0 processRewardsAndPenalties 62.699 ms/op 62.011 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 11.507 us/op 24.904 us/op 0.46
mainnet_e58758 - phase0 processSlashings 489.00 ns/op 1.8740 us/op 0.26
mainnet_e58758 - phase0 processEth1DataReset 631.00 ns/op 1.2460 us/op 0.51
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2027 ms/op 1.7601 ms/op 0.68
mainnet_e58758 - phase0 processSlashingsReset 2.7920 us/op 5.4440 us/op 0.51
mainnet_e58758 - phase0 processRandaoMixesReset 4.7400 us/op 12.913 us/op 0.37
mainnet_e58758 - phase0 processHistoricalRootsUpdate 587.00 ns/op 1.2930 us/op 0.45
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.6160 us/op 7.5960 us/op 0.48
mainnet_e58758 - phase0 afterProcessEpoch 105.40 ms/op 119.59 ms/op 0.88
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3578 ms/op 1.7889 ms/op 0.76
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4914 ms/op 2.9182 ms/op 0.51
altair processInactivityUpdates - 250000 normalcase 22.702 ms/op 31.878 ms/op 0.71
altair processInactivityUpdates - 250000 worstcase 21.505 ms/op 33.416 ms/op 0.64
phase0 processRegistryUpdates - 250000 normalcase 9.3390 us/op 22.024 us/op 0.42
phase0 processRegistryUpdates - 250000 badcase_full_deposits 421.05 us/op 723.80 us/op 0.58
phase0 processRegistryUpdates - 250000 worstcase 0.5 152.53 ms/op 217.15 ms/op 0.70
altair processRewardsAndPenalties - 250000 normalcase 51.041 ms/op 89.324 ms/op 0.57
altair processRewardsAndPenalties - 250000 worstcase 55.856 ms/op 85.414 ms/op 0.65
phase0 getAttestationDeltas - 250000 normalcase 10.346 ms/op 14.978 ms/op 0.69
phase0 getAttestationDeltas - 250000 worstcase 9.6156 ms/op 14.747 ms/op 0.65
phase0 processSlashings - 250000 worstcase 99.541 us/op 149.09 us/op 0.67
altair processSyncCommitteeUpdates - 250000 171.48 ms/op 186.25 ms/op 0.92
BeaconState.hashTreeRoot - No change 377.00 ns/op 820.00 ns/op 0.46
BeaconState.hashTreeRoot - 1 full validator 130.53 us/op 165.36 us/op 0.79
BeaconState.hashTreeRoot - 32 full validator 1.3036 ms/op 1.7205 ms/op 0.76
BeaconState.hashTreeRoot - 512 full validator 14.129 ms/op 21.641 ms/op 0.65
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 154.99 us/op 206.03 us/op 0.75
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.9371 ms/op 2.6467 ms/op 0.73
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 29.885 ms/op 38.020 ms/op 0.79
BeaconState.hashTreeRoot - 1 balances 130.86 us/op 175.68 us/op 0.74
BeaconState.hashTreeRoot - 32 balances 1.1236 ms/op 1.5925 ms/op 0.71
BeaconState.hashTreeRoot - 512 balances 11.910 ms/op 15.784 ms/op 0.75
BeaconState.hashTreeRoot - 250000 balances 183.50 ms/op 242.48 ms/op 0.76
aggregationBits - 2048 els - zipIndexesInBitList 28.860 us/op 48.298 us/op 0.60
byteArrayEquals 32 78.274 ns/op 115.05 ns/op 0.68
Buffer.compare 32 58.398 ns/op 67.474 ns/op 0.87
byteArrayEquals 1024 2.1245 us/op 2.2824 us/op 0.93
Buffer.compare 1024 72.598 ns/op 93.152 ns/op 0.78
byteArrayEquals 16384 34.342 us/op 45.140 us/op 0.76
Buffer.compare 16384 255.10 ns/op 283.07 ns/op 0.90
byteArrayEquals 123687377 250.84 ms/op 319.75 ms/op 0.78
Buffer.compare 123687377 6.5848 ms/op 12.145 ms/op 0.54
byteArrayEquals 32 - diff last byte 75.003 ns/op 92.297 ns/op 0.81
Buffer.compare 32 - diff last byte 56.862 ns/op 73.255 ns/op 0.78
byteArrayEquals 1024 - diff last byte 2.0367 us/op 2.5725 us/op 0.79
Buffer.compare 1024 - diff last byte 76.744 ns/op 86.800 ns/op 0.88
byteArrayEquals 16384 - diff last byte 32.827 us/op 37.036 us/op 0.89
Buffer.compare 16384 - diff last byte 269.68 ns/op 300.36 ns/op 0.90
byteArrayEquals 123687377 - diff last byte 254.50 ms/op 317.83 ms/op 0.80
Buffer.compare 123687377 - diff last byte 6.5261 ms/op 13.285 ms/op 0.49
byteArrayEquals 32 - random bytes 5.4870 ns/op 8.5920 ns/op 0.64
Buffer.compare 32 - random bytes 64.046 ns/op 87.609 ns/op 0.73
byteArrayEquals 1024 - random bytes 5.4480 ns/op 8.7870 ns/op 0.62
Buffer.compare 1024 - random bytes 62.543 ns/op 75.831 ns/op 0.82
byteArrayEquals 16384 - random bytes 5.3940 ns/op 8.7550 ns/op 0.62
Buffer.compare 16384 - random bytes 62.640 ns/op 76.354 ns/op 0.82
byteArrayEquals 123687377 - random bytes 8.8100 ns/op 21.340 ns/op 0.41
Buffer.compare 123687377 - random bytes 66.320 ns/op 90.070 ns/op 0.74
regular array get 100000 times 46.361 us/op 65.254 us/op 0.71
wrappedArray get 100000 times 46.745 us/op 59.678 us/op 0.78
arrayWithProxy get 100000 times 14.770 ms/op 16.892 ms/op 0.87
ssz.Root.equals 56.271 ns/op 64.385 ns/op 0.87
byteArrayEquals 55.008 ns/op 63.602 ns/op 0.86
Buffer.compare 11.350 ns/op 14.672 ns/op 0.77
shuffle list - 16384 els 8.9205 ms/op 9.5762 ms/op 0.93
shuffle list - 250000 els 130.19 ms/op 145.73 ms/op 0.89
processSlot - 1 slots 17.008 us/op 26.589 us/op 0.64
processSlot - 32 slots 2.9705 ms/op 5.6918 ms/op 0.52
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 60.442 ms/op 72.778 ms/op 0.83
getCommitteeAssignments - req 1 vs - 250000 vc 2.9607 ms/op 2.9460 ms/op 1.00
getCommitteeAssignments - req 100 vs - 250000 vc 4.2524 ms/op 4.1339 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6414 ms/op 4.7432 ms/op 0.98
findModifiedValidators - 10000 modified validators 499.61 ms/op 483.54 ms/op 1.03
findModifiedValidators - 1000 modified validators 266.72 ms/op 311.92 ms/op 0.86
findModifiedValidators - 100 modified validators 234.28 ms/op 305.58 ms/op 0.77
findModifiedValidators - 10 modified validators 248.74 ms/op 245.66 ms/op 1.01
findModifiedValidators - 1 modified validators 269.47 ms/op 252.45 ms/op 1.07
findModifiedValidators - no difference 272.30 ms/op 227.26 ms/op 1.20
compare ViewDUs 5.1398 s/op 5.5458 s/op 0.93
compare each validator Uint8Array 1.7175 s/op 2.0277 s/op 0.85
compare ViewDU to Uint8Array 1.5241 s/op 1.5043 s/op 1.01
migrate state 1000000 validators, 24 modified, 0 new 798.69 ms/op 871.52 ms/op 0.92
migrate state 1000000 validators, 1700 modified, 1000 new 1.1897 s/op 1.3018 s/op 0.91
migrate state 1000000 validators, 3400 modified, 2000 new 1.3861 s/op 1.5074 s/op 0.92
migrate state 1500000 validators, 24 modified, 0 new 751.04 ms/op 881.46 ms/op 0.85
migrate state 1500000 validators, 1700 modified, 1000 new 1.0811 s/op 1.4174 s/op 0.76
migrate state 1500000 validators, 3400 modified, 2000 new 1.2717 s/op 1.6414 s/op 0.77
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6100 ns/op 7.7500 ns/op 0.59
state getBlockRootAtSlot - 250000 vs - 7PWei 617.83 ns/op 1.2254 us/op 0.50
computeProposers - vc 250000 9.3462 ms/op 13.980 ms/op 0.67
computeEpochShuffling - vc 250000 130.88 ms/op 147.31 ms/op 0.89
getNextSyncCommittee - vc 250000 157.25 ms/op 211.70 ms/op 0.74
computeSigningRoot for AttestationData 24.803 us/op 37.229 us/op 0.67
hash AttestationData serialized data then Buffer.toString(base64) 2.4352 us/op 2.7138 us/op 0.90
toHexString serialized data 1.2882 us/op 1.6882 us/op 0.76
Buffer.toString(base64) 260.82 ns/op 291.46 ns/op 0.89

by benchmarkbot/action

@nflaig
Copy link
Member

nflaig commented Apr 15, 2024

yargs is used in utils, but not defined in the associated package.json.

not used by utils package, it explicitly just imports the types

lodestar/packages/utils/src/command.ts

Line 1 in ae984f0

import type {Options, Argv} from "yargs";

which are installed as dev dep

lodestar/packages/utils/package.json

Line 50 in ae984f0

"@types/yargs": "^17.0.24",

if anything we would just install the the types as dependency, or alternatively list it as a peer dependency. See #6441 (comment) why I went with just adding it as dev dependency.

@nflaig
Copy link
Member

nflaig commented Apr 15, 2024

Also if you look at packages/utils/lib/command.js, there is no reference to yargs anymore, it's not needed at runtime.

@jeluard
Copy link
Contributor Author

jeluard commented Apr 15, 2024

Hmm right, I was confused due to some error related to using yarn install --production. Looks like we are good.

@jeluard jeluard closed this Apr 15, 2024
@jeluard jeluard deleted the jeluard/missing-dependencies branch April 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeluard @nflaig