Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require node 18.17.0 to fix native fetch memory leak #5873

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: require node 18.17.0 to fix native fetch memory leak #5873

merged 1 commit into from
Aug 11, 2023

Conversation

matthewkeil
Copy link
Member

Motivation

Memory leak in undici and native fetch. Resolved in node 18.17.0 and 20.1.0

Description

Fixes #5851

How to Test

Deployed 18.17.0 to beta to confirm. Will move PR to ready for review once confirmed. Already validated with node 20 via @tuyennhv 's deploy and confirmed with beta and feat1 checks when researching issue.

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 688fb7d Previous: 042adb1 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 611.73 us/op 565.78 us/op 1.08
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 76.005 us/op 93.075 us/op 0.82
BLS verify - blst-native 1.2065 ms/op 1.2873 ms/op 0.94
BLS verifyMultipleSignatures 3 - blst-native 2.4554 ms/op 2.6305 ms/op 0.93
BLS verifyMultipleSignatures 8 - blst-native 5.2942 ms/op 5.6612 ms/op 0.94
BLS verifyMultipleSignatures 32 - blst-native 19.060 ms/op 20.453 ms/op 0.93
BLS aggregatePubkeys 32 - blst-native 25.464 us/op 27.186 us/op 0.94
BLS aggregatePubkeys 128 - blst-native 99.187 us/op 106.44 us/op 0.93
getAttestationsForBlock 51.657 ms/op 99.234 ms/op 0.52
isKnown best case - 1 super set check 271.00 ns/op 649.00 ns/op 0.42
isKnown normal case - 2 super set checks 276.00 ns/op 611.00 ns/op 0.45
isKnown worse case - 16 super set checks 266.00 ns/op 604.00 ns/op 0.44
CheckpointStateCache - add get delete 4.9720 us/op 8.4450 us/op 0.59
validate api signedAggregateAndProof - struct 2.7775 ms/op 3.1196 ms/op 0.89
validate gossip signedAggregateAndProof - struct 2.7813 ms/op 3.9040 ms/op 0.71
validate api attestation - struct 1.3239 ms/op 1.5890 ms/op 0.83
validate gossip attestation - struct 1.3630 ms/op 1.4302 ms/op 0.95
pickEth1Vote - no votes 1.2429 ms/op 1.4133 ms/op 0.88
pickEth1Vote - max votes 8.3127 ms/op 14.515 ms/op 0.57
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.5288 ms/op 10.978 ms/op 0.78
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 12.835 ms/op 24.812 ms/op 0.52
pickEth1Vote - Eth1Data fastSerialize value x2048 565.16 us/op 814.71 us/op 0.69
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.4489 ms/op 8.8118 ms/op 0.50
bytes32 toHexString 478.00 ns/op 933.00 ns/op 0.51
bytes32 Buffer.toString(hex) 279.00 ns/op 407.00 ns/op 0.69
bytes32 Buffer.toString(hex) from Uint8Array 435.00 ns/op 695.00 ns/op 0.63
bytes32 Buffer.toString(hex) + 0x 285.00 ns/op 354.00 ns/op 0.81
Object access 1 prop 0.15400 ns/op 0.31700 ns/op 0.49
Map access 1 prop 0.14100 ns/op 0.22400 ns/op 0.63
Object get x1000 7.1970 ns/op 12.498 ns/op 0.58
Map get x1000 0.64900 ns/op 1.0730 ns/op 0.60
Object set x1000 52.143 ns/op 108.87 ns/op 0.48
Map set x1000 39.899 ns/op 72.407 ns/op 0.55
Return object 10000 times 0.23860 ns/op 0.45030 ns/op 0.53
Throw Error 10000 times 3.8671 us/op 4.8037 us/op 0.81
fastMsgIdFn sha256 / 200 bytes 3.3360 us/op 3.6860 us/op 0.91
fastMsgIdFn h32 xxhash / 200 bytes 302.00 ns/op 400.00 ns/op 0.76
fastMsgIdFn h64 xxhash / 200 bytes 359.00 ns/op 423.00 ns/op 0.85
fastMsgIdFn sha256 / 1000 bytes 11.559 us/op 12.560 us/op 0.92
fastMsgIdFn h32 xxhash / 1000 bytes 418.00 ns/op 490.00 ns/op 0.85
fastMsgIdFn h64 xxhash / 1000 bytes 419.00 ns/op 475.00 ns/op 0.88
fastMsgIdFn sha256 / 10000 bytes 104.42 us/op 105.80 us/op 0.99
fastMsgIdFn h32 xxhash / 10000 bytes 1.9440 us/op 2.0340 us/op 0.96
fastMsgIdFn h64 xxhash / 10000 bytes 1.3280 us/op 1.4040 us/op 0.95
enrSubnets - fastDeserialize 64 bits 1.2390 us/op 1.5080 us/op 0.82
enrSubnets - ssz BitVector 64 bits 428.00 ns/op 604.00 ns/op 0.71
enrSubnets - fastDeserialize 4 bits 172.00 ns/op 238.00 ns/op 0.72
enrSubnets - ssz BitVector 4 bits 445.00 ns/op 556.00 ns/op 0.80
prioritizePeers score -10:0 att 32-0.1 sync 2-0 99.663 us/op 115.31 us/op 0.86
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 124.67 us/op 168.23 us/op 0.74
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 163.11 us/op 250.06 us/op 0.65
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 293.36 us/op 412.51 us/op 0.71
prioritizePeers score 0:0 att 64-1 sync 4-1 350.82 us/op 505.74 us/op 0.69
array of 16000 items push then shift 1.6073 us/op 1.8624 us/op 0.86
LinkedList of 16000 items push then shift 8.9770 ns/op 11.835 ns/op 0.76
array of 16000 items push then pop 56.276 ns/op 75.121 ns/op 0.75
LinkedList of 16000 items push then pop 8.9490 ns/op 10.614 ns/op 0.84
array of 24000 items push then shift 2.4126 us/op 2.6802 us/op 0.90
LinkedList of 24000 items push then shift 9.0280 ns/op 11.259 ns/op 0.80
array of 24000 items push then pop 116.82 ns/op 138.94 ns/op 0.84
LinkedList of 24000 items push then pop 8.8670 ns/op 9.6840 ns/op 0.92
intersect bitArray bitLen 8 6.8970 ns/op 7.3870 ns/op 0.93
intersect array and set length 8 64.182 ns/op 79.603 ns/op 0.81
intersect bitArray bitLen 128 32.106 ns/op 34.855 ns/op 0.92
intersect array and set length 128 856.23 ns/op 1.0309 us/op 0.83
bitArray.getTrueBitIndexes() bitLen 128 1.5700 us/op 1.8140 us/op 0.87
bitArray.getTrueBitIndexes() bitLen 248 2.6280 us/op 3.0670 us/op 0.86
bitArray.getTrueBitIndexes() bitLen 512 4.8670 us/op 6.1860 us/op 0.79
Buffer.concat 32 items 1.0830 us/op 1.0640 us/op 1.02
Uint8Array.set 32 items 1.7660 us/op 2.3240 us/op 0.76
transfer serialized Status (84 B) 1.8250 us/op 2.0650 us/op 0.88
copy serialized Status (84 B) 1.5820 us/op 1.8180 us/op 0.87
transfer serialized SignedVoluntaryExit (112 B) 1.8880 us/op 2.1200 us/op 0.89
copy serialized SignedVoluntaryExit (112 B) 1.5900 us/op 1.8610 us/op 0.85
transfer serialized ProposerSlashing (416 B) 2.0530 us/op 2.5460 us/op 0.81
copy serialized ProposerSlashing (416 B) 1.8830 us/op 2.5260 us/op 0.75
transfer serialized Attestation (485 B) 2.0360 us/op 3.4670 us/op 0.59
copy serialized Attestation (485 B) 1.8190 us/op 3.7200 us/op 0.49
transfer serialized AttesterSlashing (33232 B) 2.2700 us/op 3.3900 us/op 0.67
copy serialized AttesterSlashing (33232 B) 4.8740 us/op 10.302 us/op 0.47
transfer serialized Small SignedBeaconBlock (128000 B) 2.4860 us/op 3.8520 us/op 0.65
copy serialized Small SignedBeaconBlock (128000 B) 12.395 us/op 23.495 us/op 0.53
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8360 us/op 3.9000 us/op 0.73
copy serialized Avg SignedBeaconBlock (200000 B) 17.992 us/op 30.987 us/op 0.58
transfer serialized BlobsSidecar (524380 B) 3.0930 us/op 4.2940 us/op 0.72
copy serialized BlobsSidecar (524380 B) 81.786 us/op 88.780 us/op 0.92
transfer serialized Big SignedBeaconBlock (1000000 B) 3.3280 us/op 3.7490 us/op 0.89
copy serialized Big SignedBeaconBlock (1000000 B) 164.74 us/op 175.38 us/op 0.94
pass gossip attestations to forkchoice per slot 2.1920 ms/op 2.2836 ms/op 0.96
forkChoice updateHead vc 100000 bc 64 eq 0 2.1886 ms/op 2.6650 ms/op 0.82
forkChoice updateHead vc 600000 bc 64 eq 0 12.699 ms/op 12.546 ms/op 1.01
forkChoice updateHead vc 1000000 bc 64 eq 0 18.778 ms/op 19.314 ms/op 0.97
forkChoice updateHead vc 600000 bc 320 eq 0 18.618 ms/op 19.341 ms/op 0.96
forkChoice updateHead vc 600000 bc 1200 eq 0 82.011 ms/op 91.774 ms/op 0.89
forkChoice updateHead vc 600000 bc 64 eq 1000 19.040 ms/op 20.394 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 10000 21.337 ms/op 22.996 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 300000 28.084 ms/op 64.451 ms/op 0.44
computeDeltas 3.4275 ms/op 3.9651 ms/op 0.86
computeProposerBoostScoreFromBalances 390.68 us/op 443.03 us/op 0.88
altair processAttestation - 250000 vs - 7PWei normalcase 2.2831 ms/op 3.9585 ms/op 0.58
altair processAttestation - 250000 vs - 7PWei worstcase 4.1781 ms/op 6.0537 ms/op 0.69
altair processAttestation - setStatus - 1/6 committees join 188.46 us/op 232.94 us/op 0.81
altair processAttestation - setStatus - 1/3 committees join 354.24 us/op 467.71 us/op 0.76
altair processAttestation - setStatus - 1/2 committees join 481.39 us/op 536.95 us/op 0.90
altair processAttestation - setStatus - 2/3 committees join 616.95 us/op 663.50 us/op 0.93
altair processAttestation - setStatus - 4/5 committees join 808.03 us/op 875.31 us/op 0.92
altair processAttestation - setStatus - 100% committees join 960.84 us/op 984.19 us/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 9.9162 ms/op 11.127 ms/op 0.89
altair processBlock - 250000 vs - 7PWei normalcase hashState 16.548 ms/op 18.760 ms/op 0.88
altair processBlock - 250000 vs - 7PWei worstcase 36.728 ms/op 45.541 ms/op 0.81
altair processBlock - 250000 vs - 7PWei worstcase hashState 57.936 ms/op 71.671 ms/op 0.81
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2647 ms/op 3.7027 ms/op 0.61
phase0 processBlock - 250000 vs - 7PWei worstcase 30.478 ms/op 41.438 ms/op 0.74
altair processEth1Data - 250000 vs - 7PWei normalcase 471.63 us/op 741.59 us/op 0.64
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 12.120 us/op 21.533 us/op 0.56
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 69.340 us/op 107.74 us/op 0.64
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 21.452 us/op 34.449 us/op 0.62
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 10.639 us/op 20.059 us/op 0.53
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 167.80 us/op 158.94 us/op 1.06
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0560 ms/op 1.6507 ms/op 0.64
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.4576 ms/op 2.0828 ms/op 0.70
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.4953 ms/op 2.1329 ms/op 0.70
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.3132 ms/op 4.9253 ms/op 0.67
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.2807 ms/op 3.0921 ms/op 0.74
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.6600 ms/op 7.5608 ms/op 0.62
Tree 40 250000 create 307.05 ms/op 600.54 ms/op 0.51
Tree 40 250000 get(125000) 197.60 ns/op 216.18 ns/op 0.91
Tree 40 250000 set(125000) 921.77 ns/op 1.4785 us/op 0.62
Tree 40 250000 toArray() 18.817 ms/op 25.353 ms/op 0.74
Tree 40 250000 iterate all - toArray() + loop 19.003 ms/op 25.903 ms/op 0.73
Tree 40 250000 iterate all - get(i) 67.774 ms/op 77.494 ms/op 0.87
MutableVector 250000 create 11.143 ms/op 18.703 ms/op 0.60
MutableVector 250000 get(125000) 6.5270 ns/op 7.1240 ns/op 0.92
MutableVector 250000 set(125000) 262.37 ns/op 377.02 ns/op 0.70
MutableVector 250000 toArray() 3.1309 ms/op 4.5368 ms/op 0.69
MutableVector 250000 iterate all - toArray() + loop 3.2671 ms/op 5.0830 ms/op 0.64
MutableVector 250000 iterate all - get(i) 1.5378 ms/op 1.5915 ms/op 0.97
Array 250000 create 2.7939 ms/op 3.6925 ms/op 0.76
Array 250000 clone - spread 1.2198 ms/op 1.1119 ms/op 1.10
Array 250000 get(125000) 0.62500 ns/op 0.55000 ns/op 1.14
Array 250000 set(125000) 0.68400 ns/op 0.61800 ns/op 1.11
Array 250000 iterate all - loop 82.784 us/op 109.99 us/op 0.75
effectiveBalanceIncrements clone Uint8Array 300000 28.810 us/op 38.390 us/op 0.75
effectiveBalanceIncrements clone MutableVector 300000 376.00 ns/op 290.00 ns/op 1.30
effectiveBalanceIncrements rw all Uint8Array 300000 175.63 us/op 194.75 us/op 0.90
effectiveBalanceIncrements rw all MutableVector 300000 85.037 ms/op 95.487 ms/op 0.89
phase0 afterProcessEpoch - 250000 vs - 7PWei 114.89 ms/op 120.84 ms/op 0.95
phase0 beforeProcessEpoch - 250000 vs - 7PWei 34.028 ms/op 48.148 ms/op 0.71
altair processEpoch - mainnet_e81889 325.80 ms/op 368.29 ms/op 0.88
mainnet_e81889 - altair beforeProcessEpoch 61.130 ms/op 98.902 ms/op 0.62
mainnet_e81889 - altair processJustificationAndFinalization 15.329 us/op 45.060 us/op 0.34
mainnet_e81889 - altair processInactivityUpdates 5.2902 ms/op 13.173 ms/op 0.40
mainnet_e81889 - altair processRewardsAndPenalties 66.295 ms/op 90.336 ms/op 0.73
mainnet_e81889 - altair processRegistryUpdates 2.2380 us/op 11.021 us/op 0.20
mainnet_e81889 - altair processSlashings 522.00 ns/op 1.9780 us/op 0.26
mainnet_e81889 - altair processEth1DataReset 532.00 ns/op 2.2550 us/op 0.24
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2561 ms/op 2.8034 ms/op 0.45
mainnet_e81889 - altair processSlashingsReset 3.3380 us/op 8.7450 us/op 0.38
mainnet_e81889 - altair processRandaoMixesReset 5.7900 us/op 10.992 us/op 0.53
mainnet_e81889 - altair processHistoricalRootsUpdate 1.6520 us/op 2.0530 us/op 0.80
mainnet_e81889 - altair processParticipationFlagUpdates 4.4560 us/op 3.5810 us/op 1.24
mainnet_e81889 - altair processSyncCommitteeUpdates 1.3970 us/op 1.0420 us/op 1.34
mainnet_e81889 - altair afterProcessEpoch 137.47 ms/op 129.81 ms/op 1.06
capella processEpoch - mainnet_e217614 1.2146 s/op 1.1831 s/op 1.03
mainnet_e217614 - capella beforeProcessEpoch 251.06 ms/op 265.07 ms/op 0.95
mainnet_e217614 - capella processJustificationAndFinalization 19.126 us/op 16.465 us/op 1.16
mainnet_e217614 - capella processInactivityUpdates 17.754 ms/op 17.178 ms/op 1.03
mainnet_e217614 - capella processRewardsAndPenalties 283.56 ms/op 302.44 ms/op 0.94
mainnet_e217614 - capella processRegistryUpdates 23.904 us/op 29.099 us/op 0.82
mainnet_e217614 - capella processSlashings 585.00 ns/op 782.00 ns/op 0.75
mainnet_e217614 - capella processEth1DataReset 533.00 ns/op 607.00 ns/op 0.88
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.4886 ms/op 4.4298 ms/op 1.01
mainnet_e217614 - capella processSlashingsReset 3.5250 us/op 4.1280 us/op 0.85
mainnet_e217614 - capella processRandaoMixesReset 7.2010 us/op 6.1920 us/op 1.16
mainnet_e217614 - capella processHistoricalRootsUpdate 719.00 ns/op 772.00 ns/op 0.93
mainnet_e217614 - capella processParticipationFlagUpdates 4.7960 us/op 3.0230 us/op 1.59
mainnet_e217614 - capella afterProcessEpoch 322.51 ms/op 310.00 ms/op 1.04
phase0 processEpoch - mainnet_e58758 364.30 ms/op 368.24 ms/op 0.99
mainnet_e58758 - phase0 beforeProcessEpoch 151.82 ms/op 149.89 ms/op 1.01
mainnet_e58758 - phase0 processJustificationAndFinalization 28.060 us/op 17.590 us/op 1.60
mainnet_e58758 - phase0 processRewardsAndPenalties 61.088 ms/op 66.610 ms/op 0.92
mainnet_e58758 - phase0 processRegistryUpdates 12.916 us/op 10.845 us/op 1.19
mainnet_e58758 - phase0 processSlashings 823.00 ns/op 842.00 ns/op 0.98
mainnet_e58758 - phase0 processEth1DataReset 788.00 ns/op 532.00 ns/op 1.48
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1540 ms/op 1.0302 ms/op 1.12
mainnet_e58758 - phase0 processSlashingsReset 3.1480 us/op 2.8130 us/op 1.12
mainnet_e58758 - phase0 processRandaoMixesReset 5.2270 us/op 5.1180 us/op 1.02
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0080 us/op 640.00 ns/op 1.57
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.8690 us/op 4.8840 us/op 1.00
mainnet_e58758 - phase0 afterProcessEpoch 110.67 ms/op 102.91 ms/op 1.08
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3469 ms/op 1.3418 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.0349 ms/op 1.4800 ms/op 1.37
altair processInactivityUpdates - 250000 normalcase 30.322 ms/op 29.131 ms/op 1.04
altair processInactivityUpdates - 250000 worstcase 28.834 ms/op 27.004 ms/op 1.07
phase0 processRegistryUpdates - 250000 normalcase 16.659 us/op 10.435 us/op 1.60
phase0 processRegistryUpdates - 250000 badcase_full_deposits 392.47 us/op 384.01 us/op 1.02
phase0 processRegistryUpdates - 250000 worstcase 0.5 161.95 ms/op 127.93 ms/op 1.27
altair processRewardsAndPenalties - 250000 normalcase 86.437 ms/op 68.927 ms/op 1.25
altair processRewardsAndPenalties - 250000 worstcase 78.771 ms/op 77.636 ms/op 1.01
phase0 getAttestationDeltas - 250000 normalcase 10.257 ms/op 8.3569 ms/op 1.23
phase0 getAttestationDeltas - 250000 worstcase 10.599 ms/op 9.6392 ms/op 1.10
phase0 processSlashings - 250000 worstcase 2.4578 ms/op 2.8019 ms/op 0.88
altair processSyncCommitteeUpdates - 250000 173.62 ms/op 179.15 ms/op 0.97
BeaconState.hashTreeRoot - No change 309.00 ns/op 316.00 ns/op 0.98
BeaconState.hashTreeRoot - 1 full validator 54.668 us/op 60.518 us/op 0.90
BeaconState.hashTreeRoot - 32 full validator 621.31 us/op 637.03 us/op 0.98
BeaconState.hashTreeRoot - 512 full validator 6.1684 ms/op 7.9553 ms/op 0.78
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 67.481 us/op 72.024 us/op 0.94
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0673 ms/op 1.1787 ms/op 0.91
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.597 ms/op 14.272 ms/op 0.95
BeaconState.hashTreeRoot - 1 balances 58.136 us/op 56.509 us/op 1.03
BeaconState.hashTreeRoot - 32 balances 488.02 us/op 486.33 us/op 1.00
BeaconState.hashTreeRoot - 512 balances 6.0147 ms/op 5.7753 ms/op 1.04
BeaconState.hashTreeRoot - 250000 balances 89.136 ms/op 87.493 ms/op 1.02
aggregationBits - 2048 els - zipIndexesInBitList 27.739 us/op 27.509 us/op 1.01
regular array get 100000 times 37.904 us/op 43.231 us/op 0.88
wrappedArray get 100000 times 57.159 us/op 36.654 us/op 1.56
arrayWithProxy get 100000 times 17.735 ms/op 15.687 ms/op 1.13
ssz.Root.equals 317.00 ns/op 321.00 ns/op 0.99
byteArrayEquals 259.00 ns/op 274.00 ns/op 0.95
shuffle list - 16384 els 8.4675 ms/op 7.5608 ms/op 1.12
shuffle list - 250000 els 124.27 ms/op 111.79 ms/op 1.11
processSlot - 1 slots 9.6040 us/op 12.820 us/op 0.75
processSlot - 32 slots 1.5013 ms/op 1.4725 ms/op 1.02
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 57.595 ms/op 64.235 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 3.0038 ms/op 2.6273 ms/op 1.14
getCommitteeAssignments - req 100 vs - 250000 vc 4.1086 ms/op 3.8675 ms/op 1.06
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3847 ms/op 4.1800 ms/op 1.05
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.4900 ns/op 5.5700 ns/op 0.99
state getBlockRootAtSlot - 250000 vs - 7PWei 613.99 ns/op 880.93 ns/op 0.70
computeProposers - vc 250000 9.3709 ms/op 10.056 ms/op 0.93
computeEpochShuffling - vc 250000 114.46 ms/op 109.44 ms/op 1.05
getNextSyncCommittee - vc 250000 164.83 ms/op 160.58 ms/op 1.03
computeSigningRoot for AttestationData 14.806 us/op 14.446 us/op 1.02
hash AttestationData serialized data then Buffer.toString(base64) 2.4817 us/op 2.5188 us/op 0.99
toHexString serialized data 1.2561 us/op 1.6061 us/op 0.78
Buffer.toString(base64) 268.93 ns/op 277.46 ns/op 0.97

by benchmarkbot/action

@wemeetagain wemeetagain marked this pull request as ready for review August 11, 2023 20:07
@wemeetagain wemeetagain requested a review from a team as a code owner August 11, 2023 20:07
@wemeetagain wemeetagain merged commit 3c7b815 into unstable Aug 11, 2023
11 checks passed
@wemeetagain wemeetagain deleted the mkeil/update-node-requirement branch August 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@twoeths twoeths twoeths approved these changes

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Leak on node versions below 18.17.0
4 participants
@matthewkeil @wemeetagain @twoeths @nflaig