Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update @chainsafe/threads to 1.11.1 #5759

Merged
merged 1 commit into from
Jul 14, 2023
Merged

deps: update @chainsafe/threads to 1.11.1 #5759

merged 1 commit into from
Jul 14, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jul 14, 2023

Motivation

Closes #5552

Description

This update includes PR to fix MaxListenersExceededWarning

@nflaig nflaig requested a review from a team as a code owner July 14, 2023 16:12
@wemeetagain wemeetagain enabled auto-merge (squash) July 14, 2023 16:16
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 9b6a4b9 Previous: 96820d7 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 769.37 us/op 583.73 us/op 1.32
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 48.009 us/op 57.893 us/op 0.83
BLS verify - blst-native 1.2473 ms/op 1.2762 ms/op 0.98
BLS verifyMultipleSignatures 3 - blst-native 2.5026 ms/op 2.5874 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 5.3893 ms/op 5.5594 ms/op 0.97
BLS verifyMultipleSignatures 32 - blst-native 19.564 ms/op 20.313 ms/op 0.96
BLS aggregatePubkeys 32 - blst-native 26.569 us/op 27.002 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 102.10 us/op 105.31 us/op 0.97
getAttestationsForBlock 56.315 ms/op 75.681 ms/op 0.74
isKnown best case - 1 super set check 253.00 ns/op 274.00 ns/op 0.92
isKnown normal case - 2 super set checks 249.00 ns/op 260.00 ns/op 0.96
isKnown worse case - 16 super set checks 247.00 ns/op 267.00 ns/op 0.93
CheckpointStateCache - add get delete 5.3790 us/op 5.5690 us/op 0.97
validate gossip signedAggregateAndProof - struct 2.8500 ms/op 2.8622 ms/op 1.00
validate gossip attestation - struct 1.3241 ms/op 1.3678 ms/op 0.97
pickEth1Vote - no votes 1.2734 ms/op 1.4016 ms/op 0.91
pickEth1Vote - max votes 8.6671 ms/op 12.340 ms/op 0.70
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.6777 ms/op 9.8472 ms/op 0.88
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.516 ms/op 17.970 ms/op 0.81
pickEth1Vote - Eth1Data fastSerialize value x2048 718.42 us/op 806.67 us/op 0.89
pickEth1Vote - Eth1Data fastSerialize tree x2048 8.5056 ms/op 7.0576 ms/op 1.21
bytes32 toHexString 508.00 ns/op 644.00 ns/op 0.79
bytes32 Buffer.toString(hex) 381.00 ns/op 424.00 ns/op 0.90
bytes32 Buffer.toString(hex) from Uint8Array 583.00 ns/op 624.00 ns/op 0.93
bytes32 Buffer.toString(hex) + 0x 373.00 ns/op 427.00 ns/op 0.87
Object access 1 prop 0.18100 ns/op 0.19900 ns/op 0.91
Map access 1 prop 0.17000 ns/op 0.17400 ns/op 0.98
Object get x1000 6.8620 ns/op 6.7270 ns/op 1.02
Map get x1000 0.60600 ns/op 0.69400 ns/op 0.87
Object set x1000 57.898 ns/op 76.561 ns/op 0.76
Map set x1000 54.737 ns/op 58.446 ns/op 0.94
Return object 10000 times 0.25000 ns/op 0.28260 ns/op 0.88
Throw Error 10000 times 4.2938 us/op 4.4238 us/op 0.97
fastMsgIdFn sha256 / 200 bytes 3.6380 us/op 3.7860 us/op 0.96
fastMsgIdFn h32 xxhash / 200 bytes 323.00 ns/op 336.00 ns/op 0.96
fastMsgIdFn h64 xxhash / 200 bytes 473.00 ns/op 519.00 ns/op 0.91
fastMsgIdFn sha256 / 1000 bytes 12.127 us/op 12.247 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 451.00 ns/op 483.00 ns/op 0.93
fastMsgIdFn h64 xxhash / 1000 bytes 522.00 ns/op 545.00 ns/op 0.96
fastMsgIdFn sha256 / 10000 bytes 104.82 us/op 108.72 us/op 0.96
fastMsgIdFn h32 xxhash / 10000 bytes 2.0060 us/op 2.0370 us/op 0.98
fastMsgIdFn h64 xxhash / 10000 bytes 1.4650 us/op 1.4360 us/op 1.02
enrSubnets - fastDeserialize 64 bits 1.3470 us/op 1.6330 us/op 0.82
enrSubnets - ssz BitVector 64 bits 517.00 ns/op 593.00 ns/op 0.87
enrSubnets - fastDeserialize 4 bits 189.00 ns/op 210.00 ns/op 0.90
enrSubnets - ssz BitVector 4 bits 514.00 ns/op 594.00 ns/op 0.87
prioritizePeers score -10:0 att 32-0.1 sync 2-0 110.11 us/op 127.40 us/op 0.86
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 160.30 us/op 167.44 us/op 0.96
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 199.20 us/op 206.35 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 362.80 us/op 368.00 us/op 0.99
prioritizePeers score 0:0 att 64-1 sync 4-1 431.53 us/op 478.01 us/op 0.90
array of 16000 items push then shift 1.6858 us/op 1.8060 us/op 0.93
LinkedList of 16000 items push then shift 8.9810 ns/op 10.032 ns/op 0.90
array of 16000 items push then pop 110.77 ns/op 126.57 ns/op 0.88
LinkedList of 16000 items push then pop 9.0540 ns/op 10.088 ns/op 0.90
array of 24000 items push then shift 2.4034 us/op 2.5024 us/op 0.96
LinkedList of 24000 items push then shift 9.2010 ns/op 9.8590 ns/op 0.93
array of 24000 items push then pop 90.824 ns/op 95.535 ns/op 0.95
LinkedList of 24000 items push then pop 8.9090 ns/op 9.2410 ns/op 0.96
intersect bitArray bitLen 8 13.473 ns/op 13.963 ns/op 0.96
intersect array and set length 8 93.861 ns/op 99.567 ns/op 0.94
intersect bitArray bitLen 128 46.082 ns/op 47.718 ns/op 0.97
intersect array and set length 128 1.2522 us/op 1.2643 us/op 0.99
Buffer.concat 32 items 3.1280 us/op 3.4540 us/op 0.91
Uint8Array.set 32 items 2.9350 us/op 2.5940 us/op 1.13
transfer serialized Status (84 B) 2.3530 us/op 2.2040 us/op 1.07
copy serialized Status (84 B) 1.9340 us/op 1.8150 us/op 1.07
transfer serialized SignedVoluntaryExit (112 B) 2.4890 us/op 2.1940 us/op 1.13
copy serialized SignedVoluntaryExit (112 B) 1.9270 us/op 1.8320 us/op 1.05
transfer serialized ProposerSlashing (416 B) 2.8360 us/op 2.6950 us/op 1.05
copy serialized ProposerSlashing (416 B) 2.7920 us/op 2.8330 us/op 0.99
transfer serialized Attestation (485 B) 2.8520 us/op 3.2010 us/op 0.89
copy serialized Attestation (485 B) 2.8570 us/op 3.1510 us/op 0.91
transfer serialized AttesterSlashing (33232 B) 2.6550 us/op 3.3370 us/op 0.80
copy serialized AttesterSlashing (33232 B) 5.9090 us/op 11.548 us/op 0.51
transfer serialized Small SignedBeaconBlock (128000 B) 3.0500 us/op 3.4460 us/op 0.89
copy serialized Small SignedBeaconBlock (128000 B) 45.158 us/op 26.172 us/op 1.73
transfer serialized Avg SignedBeaconBlock (200000 B) 3.5320 us/op 4.0140 us/op 0.88
copy serialized Avg SignedBeaconBlock (200000 B) 23.913 us/op 38.977 us/op 0.61
transfer serialized BlobsSidecar (524380 B) 3.8220 us/op 4.9730 us/op 0.77
copy serialized BlobsSidecar (524380 B) 171.03 us/op 117.28 us/op 1.46
transfer serialized Big SignedBeaconBlock (1000000 B) 3.8920 us/op 4.7770 us/op 0.81
copy serialized Big SignedBeaconBlock (1000000 B) 296.51 us/op 327.44 us/op 0.91
pass gossip attestations to forkchoice per slot 2.7908 ms/op 2.8886 ms/op 0.97
forkChoice updateHead vc 100000 bc 64 eq 0 2.1987 ms/op 2.1982 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 0 13.037 ms/op 15.525 ms/op 0.84
forkChoice updateHead vc 1000000 bc 64 eq 0 23.129 ms/op 22.030 ms/op 1.05
forkChoice updateHead vc 600000 bc 320 eq 0 17.019 ms/op 18.398 ms/op 0.93
forkChoice updateHead vc 600000 bc 1200 eq 0 91.329 ms/op 96.298 ms/op 0.95
forkChoice updateHead vc 600000 bc 64 eq 1000 22.526 ms/op 23.047 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 10000 22.616 ms/op 24.503 ms/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 300000 29.547 ms/op 68.278 ms/op 0.43
computeDeltas 3.1359 ms/op 4.3505 ms/op 0.72
computeProposerBoostScoreFromBalances 1.8204 ms/op 1.8764 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 2.6951 ms/op 3.4743 ms/op 0.78
altair processAttestation - 250000 vs - 7PWei worstcase 4.2122 ms/op 5.1019 ms/op 0.83
altair processAttestation - setStatus - 1/6 committees join 146.45 us/op 158.03 us/op 0.93
altair processAttestation - setStatus - 1/3 committees join 284.55 us/op 299.99 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 379.03 us/op 405.82 us/op 0.93
altair processAttestation - setStatus - 2/3 committees join 492.42 us/op 496.95 us/op 0.99
altair processAttestation - setStatus - 4/5 committees join 675.16 us/op 700.23 us/op 0.96
altair processAttestation - setStatus - 100% committees join 782.46 us/op 816.27 us/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 17.251 ms/op 20.420 ms/op 0.84
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.339 ms/op 29.318 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase 49.494 ms/op 57.429 ms/op 0.86
altair processBlock - 250000 vs - 7PWei worstcase hashState 76.825 ms/op 73.222 ms/op 1.05
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1905 ms/op 2.5953 ms/op 0.84
phase0 processBlock - 250000 vs - 7PWei worstcase 30.438 ms/op 35.230 ms/op 0.86
altair processEth1Data - 250000 vs - 7PWei normalcase 586.13 us/op 518.58 us/op 1.13
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.5370 us/op 10.903 us/op 0.87
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 28.792 us/op 34.119 us/op 0.84
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 12.338 us/op 11.826 us/op 1.04
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.8810 us/op 12.223 us/op 0.81
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 115.10 us/op 115.11 us/op 1.00
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0190 ms/op 817.49 us/op 1.25
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 968.33 us/op 1.0734 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 908.30 us/op 1.0256 ms/op 0.89
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.5993 ms/op 2.4016 ms/op 1.08
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.8645 ms/op 1.5264 ms/op 1.22
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.0121 ms/op 4.1674 ms/op 0.96
Tree 40 250000 create 371.38 ms/op 329.14 ms/op 1.13
Tree 40 250000 get(125000) 193.52 ns/op 199.48 ns/op 0.97
Tree 40 250000 set(125000) 981.42 ns/op 999.75 ns/op 0.98
Tree 40 250000 toArray() 20.598 ms/op 23.593 ms/op 0.87
Tree 40 250000 iterate all - toArray() + loop 22.623 ms/op 23.452 ms/op 0.96
Tree 40 250000 iterate all - get(i) 74.849 ms/op 79.619 ms/op 0.94
MutableVector 250000 create 12.062 ms/op 14.075 ms/op 0.86
MutableVector 250000 get(125000) 6.6620 ns/op 6.6860 ns/op 1.00
MutableVector 250000 set(125000) 266.86 ns/op 246.02 ns/op 1.08
MutableVector 250000 toArray() 3.6512 ms/op 3.2736 ms/op 1.12
MutableVector 250000 iterate all - toArray() + loop 3.6620 ms/op 3.6863 ms/op 0.99
MutableVector 250000 iterate all - get(i) 1.5482 ms/op 1.5701 ms/op 0.99
Array 250000 create 3.7420 ms/op 2.7437 ms/op 1.36
Array 250000 clone - spread 1.2384 ms/op 1.1648 ms/op 1.06
Array 250000 get(125000) 0.60500 ns/op 0.57700 ns/op 1.05
Array 250000 set(125000) 0.67900 ns/op 0.66100 ns/op 1.03
Array 250000 iterate all - loop 92.029 us/op 84.473 us/op 1.09
effectiveBalanceIncrements clone Uint8Array 300000 45.631 us/op 40.900 us/op 1.12
effectiveBalanceIncrements clone MutableVector 300000 364.00 ns/op 345.00 ns/op 1.06
effectiveBalanceIncrements rw all Uint8Array 300000 171.81 us/op 165.95 us/op 1.04
effectiveBalanceIncrements rw all MutableVector 300000 89.855 ms/op 83.326 ms/op 1.08
phase0 afterProcessEpoch - 250000 vs - 7PWei 119.72 ms/op 121.18 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 46.476 ms/op 43.997 ms/op 1.06
altair processEpoch - mainnet_e81889 317.09 ms/op 359.24 ms/op 0.88
mainnet_e81889 - altair beforeProcessEpoch 53.177 ms/op 70.733 ms/op 0.75
mainnet_e81889 - altair processJustificationAndFinalization 21.632 us/op 18.970 us/op 1.14
mainnet_e81889 - altair processInactivityUpdates 6.0855 ms/op 5.6098 ms/op 1.08
mainnet_e81889 - altair processRewardsAndPenalties 70.685 ms/op 56.410 ms/op 1.25
mainnet_e81889 - altair processRegistryUpdates 2.8880 us/op 3.4640 us/op 0.83
mainnet_e81889 - altair processSlashings 575.00 ns/op 486.00 ns/op 1.18
mainnet_e81889 - altair processEth1DataReset 622.00 ns/op 570.00 ns/op 1.09
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2733 ms/op 1.4897 ms/op 0.85
mainnet_e81889 - altair processSlashingsReset 4.4360 us/op 7.7250 us/op 0.57
mainnet_e81889 - altair processRandaoMixesReset 7.6030 us/op 8.3060 us/op 0.92
mainnet_e81889 - altair processHistoricalRootsUpdate 1.3710 us/op 826.00 ns/op 1.66
mainnet_e81889 - altair processParticipationFlagUpdates 2.7390 us/op 2.9400 us/op 0.93
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0400 us/op 742.00 ns/op 1.40
mainnet_e81889 - altair afterProcessEpoch 128.61 ms/op 128.65 ms/op 1.00
phase0 processEpoch - mainnet_e58758 383.36 ms/op 383.47 ms/op 1.00
mainnet_e58758 - phase0 beforeProcessEpoch 154.70 ms/op 122.77 ms/op 1.26
mainnet_e58758 - phase0 processJustificationAndFinalization 28.772 us/op 18.406 us/op 1.56
mainnet_e58758 - phase0 processRewardsAndPenalties 64.843 ms/op 70.512 ms/op 0.92
mainnet_e58758 - phase0 processRegistryUpdates 14.295 us/op 10.539 us/op 1.36
mainnet_e58758 - phase0 processSlashings 1.0270 us/op 716.00 ns/op 1.43
mainnet_e58758 - phase0 processEth1DataReset 1.2620 us/op 574.00 ns/op 2.20
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3850 ms/op 1.4671 ms/op 0.94
mainnet_e58758 - phase0 processSlashingsReset 7.2120 us/op 4.0500 us/op 1.78
mainnet_e58758 - phase0 processRandaoMixesReset 8.0750 us/op 4.9910 us/op 1.62
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0570 us/op 1.0570 us/op 1.00
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.2530 us/op 4.7610 us/op 0.89
mainnet_e58758 - phase0 afterProcessEpoch 112.23 ms/op 99.295 ms/op 1.13
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3507 ms/op 1.9899 ms/op 0.68
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8292 ms/op 1.9327 ms/op 0.95
altair processInactivityUpdates - 250000 normalcase 31.744 ms/op 27.574 ms/op 1.15
altair processInactivityUpdates - 250000 worstcase 33.362 ms/op 26.069 ms/op 1.28
phase0 processRegistryUpdates - 250000 normalcase 12.553 us/op 7.3860 us/op 1.70
phase0 processRegistryUpdates - 250000 badcase_full_deposits 320.01 us/op 358.82 us/op 0.89
phase0 processRegistryUpdates - 250000 worstcase 0.5 149.22 ms/op 136.70 ms/op 1.09
altair processRewardsAndPenalties - 250000 normalcase 81.292 ms/op 70.418 ms/op 1.15
altair processRewardsAndPenalties - 250000 worstcase 75.207 ms/op 75.895 ms/op 0.99
phase0 getAttestationDeltas - 250000 normalcase 9.0484 ms/op 6.8624 ms/op 1.32
phase0 getAttestationDeltas - 250000 worstcase 6.8843 ms/op 7.3051 ms/op 0.94
phase0 processSlashings - 250000 worstcase 3.8684 ms/op 3.4628 ms/op 1.12
altair processSyncCommitteeUpdates - 250000 198.09 ms/op 183.67 ms/op 1.08
BeaconState.hashTreeRoot - No change 266.00 ns/op 263.00 ns/op 1.01
BeaconState.hashTreeRoot - 1 full validator 54.573 us/op 60.209 us/op 0.91
BeaconState.hashTreeRoot - 32 full validator 588.71 us/op 605.06 us/op 0.97
BeaconState.hashTreeRoot - 512 full validator 5.4860 ms/op 5.1265 ms/op 1.07
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 67.890 us/op 64.525 us/op 1.05
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 970.98 us/op 980.71 us/op 0.99
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.833 ms/op 12.848 ms/op 0.92
BeaconState.hashTreeRoot - 1 balances 49.965 us/op 51.717 us/op 0.97
BeaconState.hashTreeRoot - 32 balances 462.02 us/op 495.73 us/op 0.93
BeaconState.hashTreeRoot - 512 balances 4.9943 ms/op 4.6539 ms/op 1.07
BeaconState.hashTreeRoot - 250000 balances 75.538 ms/op 77.420 ms/op 0.98
aggregationBits - 2048 els - zipIndexesInBitList 17.345 us/op 16.998 us/op 1.02
regular array get 100000 times 34.228 us/op 33.518 us/op 1.02
wrappedArray get 100000 times 33.738 us/op 33.484 us/op 1.01
arrayWithProxy get 100000 times 16.977 ms/op 16.100 ms/op 1.05
ssz.Root.equals 614.00 ns/op 560.00 ns/op 1.10
byteArrayEquals 581.00 ns/op 545.00 ns/op 1.07
shuffle list - 16384 els 7.1309 ms/op 7.0629 ms/op 1.01
shuffle list - 250000 els 108.33 ms/op 102.36 ms/op 1.06
processSlot - 1 slots 9.5980 us/op 9.9050 us/op 0.97
processSlot - 32 slots 1.5997 ms/op 1.6444 ms/op 0.97
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 36.894 ms/op 39.456 ms/op 0.94
getCommitteeAssignments - req 1 vs - 250000 vc 2.9320 ms/op 2.9502 ms/op 0.99
getCommitteeAssignments - req 100 vs - 250000 vc 4.1753 ms/op 4.1630 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5158 ms/op 4.5634 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6400 ns/op 4.7300 ns/op 0.98
state getBlockRootAtSlot - 250000 vs - 7PWei 569.44 ns/op 581.21 ns/op 0.98
computeProposers - vc 250000 10.441 ms/op 10.585 ms/op 0.99
computeEpochShuffling - vc 250000 103.37 ms/op 103.25 ms/op 1.00
getNextSyncCommittee - vc 250000 176.35 ms/op 176.92 ms/op 1.00
computeSigningRoot for AttestationData 13.019 us/op 14.575 us/op 0.89
hash AttestationData serialized data then Buffer.toString(base64) 2.4430 us/op 2.6368 us/op 0.93
toHexString serialized data 1.0971 us/op 1.1622 us/op 0.94
Buffer.toString(base64) 336.37 ns/op 344.95 ns/op 0.98

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 34472f4 into unstable Jul 14, 2023
11 checks passed
@wemeetagain wemeetagain deleted the nflaig/update-threads branch July 14, 2023 16:30
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.9.0-rc.0: Worker max listeners warning
2 participants
@nflaig @wemeetagain