Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not warn out-of-synced status at start up #5708

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: do not warn out-of-synced status at start up #5708

merged 1 commit into from
Jun 26, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 26, 2023

Motivation

The log "Node sync has fallen behind" is supposed to be printed when node is synced then fall behind but due to the refactor in v1.9.0-rc.3 it was printed a lot at startup time https://github.com/ChainSafe/lodestar/pull/5654/files#diff-f81e8224c621996ff7eea63ede6fc6414724030fdde3e9d8db72eb3eadd36e58R223

Description

Only print the log when node is synced, similar to v1.8.0 https://github.com/ChainSafe/lodestar/blob/v1.8.0/packages/beacon-node/src/sync/sync.ts#L216

Closes #5685

@twoeths twoeths requested a review from a team as a code owner June 26, 2023 09:52
nflaig
nflaig approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Logs are no longer printed on startup

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 30324aa Previous: f5d12a8 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 926.41 us/op 598.89 us/op 1.55
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 47.728 us/op 57.417 us/op 0.83
BLS verify - blst-native 1.2509 ms/op 1.2633 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.5366 ms/op 2.5398 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 5.4100 ms/op 5.3910 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 19.697 ms/op 19.518 ms/op 1.01
BLS aggregatePubkeys 32 - blst-native 26.256 us/op 26.558 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 102.34 us/op 103.67 us/op 0.99
getAttestationsForBlock 52.786 ms/op 61.260 ms/op 0.86
isKnown best case - 1 super set check 249.00 ns/op 279.00 ns/op 0.89
isKnown normal case - 2 super set checks 247.00 ns/op 276.00 ns/op 0.89
isKnown worse case - 16 super set checks 250.00 ns/op 267.00 ns/op 0.94
CheckpointStateCache - add get delete 5.1910 us/op 5.6170 us/op 0.92
validate gossip signedAggregateAndProof - struct 2.7944 ms/op 2.8075 ms/op 1.00
validate gossip attestation - struct 1.3390 ms/op 1.3328 ms/op 1.00
pickEth1Vote - no votes 1.3175 ms/op 1.3730 ms/op 0.96
pickEth1Vote - max votes 9.0710 ms/op 11.814 ms/op 0.77
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.8929 ms/op 9.8277 ms/op 0.90
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.441 ms/op 15.791 ms/op 0.85
pickEth1Vote - Eth1Data fastSerialize value x2048 686.36 us/op 787.34 us/op 0.87
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.5420 ms/op 6.6871 ms/op 0.68
bytes32 toHexString 521.00 ns/op 590.00 ns/op 0.88
bytes32 Buffer.toString(hex) 388.00 ns/op 394.00 ns/op 0.98
bytes32 Buffer.toString(hex) from Uint8Array 572.00 ns/op 641.00 ns/op 0.89
bytes32 Buffer.toString(hex) + 0x 367.00 ns/op 397.00 ns/op 0.92
Object access 1 prop 0.18500 ns/op 0.19200 ns/op 0.96
Map access 1 prop 0.16500 ns/op 0.17000 ns/op 0.97
Object get x1000 6.7060 ns/op 6.6090 ns/op 1.01
Map get x1000 0.64600 ns/op 0.60500 ns/op 1.07
Object set x1000 54.040 ns/op 56.496 ns/op 0.96
Map set x1000 43.451 ns/op 45.751 ns/op 0.95
Return object 10000 times 0.24200 ns/op 0.24240 ns/op 1.00
Throw Error 10000 times 4.2165 us/op 4.3690 us/op 0.97
fastMsgIdFn sha256 / 200 bytes 3.5240 us/op 3.5150 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 292.00 ns/op 311.00 ns/op 0.94
fastMsgIdFn h64 xxhash / 200 bytes 418.00 ns/op 458.00 ns/op 0.91
fastMsgIdFn sha256 / 1000 bytes 11.769 us/op 11.763 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 416.00 ns/op 443.00 ns/op 0.94
fastMsgIdFn h64 xxhash / 1000 bytes 503.00 ns/op 542.00 ns/op 0.93
fastMsgIdFn sha256 / 10000 bytes 104.39 us/op 103.92 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9450 us/op 1.9990 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.3950 us/op 1.4730 us/op 0.95
enrSubnets - fastDeserialize 64 bits 1.3450 us/op 1.4240 us/op 0.94
enrSubnets - ssz BitVector 64 bits 529.00 ns/op 609.00 ns/op 0.87
enrSubnets - fastDeserialize 4 bits 198.00 ns/op 204.00 ns/op 0.97
enrSubnets - ssz BitVector 4 bits 531.00 ns/op 590.00 ns/op 0.90
prioritizePeers score -10:0 att 32-0.1 sync 2-0 110.79 us/op 116.33 us/op 0.95
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 150.10 us/op 159.58 us/op 0.94
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 180.19 us/op 180.35 us/op 1.00
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 374.53 us/op 352.86 us/op 1.06
prioritizePeers score 0:0 att 64-1 sync 4-1 393.49 us/op 417.57 us/op 0.94
array of 16000 items push then shift 1.7124 us/op 1.6686 us/op 1.03
LinkedList of 16000 items push then shift 9.1240 ns/op 9.0720 ns/op 1.01
array of 16000 items push then pop 93.489 ns/op 119.10 ns/op 0.78
LinkedList of 16000 items push then pop 8.9430 ns/op 8.9990 ns/op 0.99
array of 24000 items push then shift 2.4267 us/op 2.3905 us/op 1.02
LinkedList of 24000 items push then shift 9.1980 ns/op 9.2030 ns/op 1.00
array of 24000 items push then pop 78.457 ns/op 81.382 ns/op 0.96
LinkedList of 24000 items push then pop 8.8510 ns/op 8.9370 ns/op 0.99
intersect bitArray bitLen 8 13.946 ns/op 13.485 ns/op 1.03
intersect array and set length 8 78.541 ns/op 85.289 ns/op 0.92
intersect bitArray bitLen 128 45.486 ns/op 44.463 ns/op 1.02
intersect array and set length 128 1.1017 us/op 1.1320 us/op 0.97
Buffer.concat 32 items 2.7280 us/op 2.9940 us/op 0.91
Uint8Array.set 32 items 2.2210 us/op 2.7350 us/op 0.81
transfer serialized Status (84 B) 2.0090 us/op 2.2030 us/op 0.91
copy serialized Status (84 B) 1.7030 us/op 1.8280 us/op 0.93
transfer serialized SignedVoluntaryExit (112 B) 2.1060 us/op 2.3490 us/op 0.90
copy serialized SignedVoluntaryExit (112 B) 1.7300 us/op 1.9900 us/op 0.87
transfer serialized ProposerSlashing (416 B) 2.3860 us/op 3.3370 us/op 0.72
copy serialized ProposerSlashing (416 B) 2.2040 us/op 3.0270 us/op 0.73
transfer serialized Attestation (485 B) 2.3760 us/op 2.6420 us/op 0.90
copy serialized Attestation (485 B) 2.5450 us/op 2.8100 us/op 0.91
transfer serialized AttesterSlashing (33232 B) 2.6950 us/op 3.0790 us/op 0.88
copy serialized AttesterSlashing (33232 B) 6.5440 us/op 5.8300 us/op 1.12
transfer serialized Small SignedBeaconBlock (128000 B) 3.1750 us/op 2.8290 us/op 1.12
copy serialized Small SignedBeaconBlock (128000 B) 16.155 us/op 14.523 us/op 1.11
transfer serialized Avg SignedBeaconBlock (200000 B) 3.4600 us/op 3.1230 us/op 1.11
copy serialized Avg SignedBeaconBlock (200000 B) 23.097 us/op 19.106 us/op 1.21
transfer serialized BlobsSidecar (524380 B) 3.1730 us/op 3.1710 us/op 1.00
copy serialized BlobsSidecar (524380 B) 157.02 us/op 127.82 us/op 1.23
transfer serialized Big SignedBeaconBlock (1000000 B) 3.4410 us/op 3.5500 us/op 0.97
copy serialized Big SignedBeaconBlock (1000000 B) 266.85 us/op 246.71 us/op 1.08
pass gossip attestations to forkchoice per slot 2.7658 ms/op 2.6819 ms/op 1.03
forkChoice updateHead vc 100000 bc 64 eq 0 2.0847 ms/op 2.0815 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 0 12.464 ms/op 11.630 ms/op 1.07
forkChoice updateHead vc 1000000 bc 64 eq 0 19.052 ms/op 21.977 ms/op 0.87
forkChoice updateHead vc 600000 bc 320 eq 0 17.959 ms/op 16.631 ms/op 1.08
forkChoice updateHead vc 600000 bc 1200 eq 0 89.472 ms/op 82.067 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 1000 21.091 ms/op 20.712 ms/op 1.02
forkChoice updateHead vc 600000 bc 64 eq 10000 23.502 ms/op 22.765 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 300000 35.474 ms/op 31.201 ms/op 1.14
computeDeltas 3.1955 ms/op 3.2630 ms/op 0.98
computeProposerBoostScoreFromBalances 1.8342 ms/op 1.7758 ms/op 1.03
altair processAttestation - 250000 vs - 7PWei normalcase 2.8193 ms/op 2.3120 ms/op 1.22
altair processAttestation - 250000 vs - 7PWei worstcase 4.2044 ms/op 3.4024 ms/op 1.24
altair processAttestation - setStatus - 1/6 committees join 144.89 us/op 142.77 us/op 1.01
altair processAttestation - setStatus - 1/3 committees join 301.77 us/op 274.98 us/op 1.10
altair processAttestation - setStatus - 1/2 committees join 383.66 us/op 375.37 us/op 1.02
altair processAttestation - setStatus - 2/3 committees join 482.00 us/op 463.81 us/op 1.04
altair processAttestation - setStatus - 4/5 committees join 678.43 us/op 679.04 us/op 1.00
altair processAttestation - setStatus - 100% committees join 774.29 us/op 761.45 us/op 1.02
altair processBlock - 250000 vs - 7PWei normalcase 18.960 ms/op 17.744 ms/op 1.07
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.997 ms/op 27.525 ms/op 0.94
altair processBlock - 250000 vs - 7PWei worstcase 54.218 ms/op 49.667 ms/op 1.09
altair processBlock - 250000 vs - 7PWei worstcase hashState 75.195 ms/op 73.708 ms/op 1.02
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3508 ms/op 1.9894 ms/op 1.18
phase0 processBlock - 250000 vs - 7PWei worstcase 32.303 ms/op 28.994 ms/op 1.11
altair processEth1Data - 250000 vs - 7PWei normalcase 559.82 us/op 487.81 us/op 1.15
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.6230 us/op 8.3730 us/op 1.03
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 27.787 us/op 24.594 us/op 1.13
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 14.097 us/op 10.450 us/op 1.35
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.8350 us/op 7.7850 us/op 1.26
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 112.76 us/op 95.787 us/op 1.18
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 689.68 us/op 637.78 us/op 1.08
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 914.08 us/op 924.88 us/op 0.99
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 912.83 us/op 874.61 us/op 1.04
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4279 ms/op 2.3686 ms/op 1.03
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.6178 ms/op 1.5781 ms/op 1.03
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9716 ms/op 4.2187 ms/op 0.94
Tree 40 250000 create 333.99 ms/op 339.16 ms/op 0.98
Tree 40 250000 get(125000) 195.66 ns/op 198.05 ns/op 0.99
Tree 40 250000 set(125000) 1.0220 us/op 1.0315 us/op 0.99
Tree 40 250000 toArray() 23.128 ms/op 26.719 ms/op 0.87
Tree 40 250000 iterate all - toArray() + loop 27.519 ms/op 21.562 ms/op 1.28
Tree 40 250000 iterate all - get(i) 78.350 ms/op 71.706 ms/op 1.09
MutableVector 250000 create 13.694 ms/op 10.698 ms/op 1.28
MutableVector 250000 get(125000) 6.7220 ns/op 6.5030 ns/op 1.03
MutableVector 250000 set(125000) 272.27 ns/op 258.58 ns/op 1.05
MutableVector 250000 toArray() 3.1736 ms/op 2.9148 ms/op 1.09
MutableVector 250000 iterate all - toArray() + loop 3.4467 ms/op 3.0535 ms/op 1.13
MutableVector 250000 iterate all - get(i) 1.6359 ms/op 1.5297 ms/op 1.07
Array 250000 create 3.1321 ms/op 2.7748 ms/op 1.13
Array 250000 clone - spread 1.2085 ms/op 1.2422 ms/op 0.97
Array 250000 get(125000) 0.59400 ns/op 0.63300 ns/op 0.94
Array 250000 set(125000) 0.68300 ns/op 0.70300 ns/op 0.97
Array 250000 iterate all - loop 86.112 us/op 84.631 us/op 1.02
effectiveBalanceIncrements clone Uint8Array 300000 41.744 us/op 35.597 us/op 1.17
effectiveBalanceIncrements clone MutableVector 300000 370.00 ns/op 368.00 ns/op 1.01
effectiveBalanceIncrements rw all Uint8Array 300000 175.72 us/op 173.50 us/op 1.01
effectiveBalanceIncrements rw all MutableVector 300000 99.125 ms/op 87.676 ms/op 1.13
phase0 afterProcessEpoch - 250000 vs - 7PWei 121.26 ms/op 119.56 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.430 ms/op 41.093 ms/op 1.06
altair processEpoch - mainnet_e81889 327.34 ms/op 339.58 ms/op 0.96
mainnet_e81889 - altair beforeProcessEpoch 56.999 ms/op 70.493 ms/op 0.81
mainnet_e81889 - altair processJustificationAndFinalization 22.098 us/op 19.117 us/op 1.16
mainnet_e81889 - altair processInactivityUpdates 6.1143 ms/op 6.0615 ms/op 1.01
mainnet_e81889 - altair processRewardsAndPenalties 54.722 ms/op 54.846 ms/op 1.00
mainnet_e81889 - altair processRegistryUpdates 3.6900 us/op 2.6220 us/op 1.41
mainnet_e81889 - altair processSlashings 896.00 ns/op 599.00 ns/op 1.50
mainnet_e81889 - altair processEth1DataReset 819.00 ns/op 702.00 ns/op 1.17
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3277 ms/op 1.2679 ms/op 1.05
mainnet_e81889 - altair processSlashingsReset 4.9740 us/op 4.9670 us/op 1.00
mainnet_e81889 - altair processRandaoMixesReset 4.7170 us/op 4.4610 us/op 1.06
mainnet_e81889 - altair processHistoricalRootsUpdate 941.00 ns/op 1.1060 us/op 0.85
mainnet_e81889 - altair processParticipationFlagUpdates 6.6460 us/op 3.3620 us/op 1.98
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0360 us/op 947.00 ns/op 1.09
mainnet_e81889 - altair afterProcessEpoch 134.16 ms/op 121.32 ms/op 1.11
phase0 processEpoch - mainnet_e58758 378.15 ms/op 365.61 ms/op 1.03
mainnet_e58758 - phase0 beforeProcessEpoch 148.38 ms/op 153.39 ms/op 0.97
mainnet_e58758 - phase0 processJustificationAndFinalization 32.055 us/op 24.813 us/op 1.29
mainnet_e58758 - phase0 processRewardsAndPenalties 64.105 ms/op 74.836 ms/op 0.86
mainnet_e58758 - phase0 processRegistryUpdates 8.6820 us/op 10.662 us/op 0.81
mainnet_e58758 - phase0 processSlashings 962.00 ns/op 722.00 ns/op 1.33
mainnet_e58758 - phase0 processEth1DataReset 740.00 ns/op 835.00 ns/op 0.89
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0671 ms/op 1.1497 ms/op 0.93
mainnet_e58758 - phase0 processSlashingsReset 3.8850 us/op 4.4240 us/op 0.88
mainnet_e58758 - phase0 processRandaoMixesReset 5.1170 us/op 5.2350 us/op 0.98
mainnet_e58758 - phase0 processHistoricalRootsUpdate 729.00 ns/op 907.00 ns/op 0.80
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.0240 us/op 5.8460 us/op 0.86
mainnet_e58758 - phase0 afterProcessEpoch 100.76 ms/op 104.89 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2656 ms/op 1.2908 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5528 ms/op 1.6286 ms/op 0.95
altair processInactivityUpdates - 250000 normalcase 26.018 ms/op 28.401 ms/op 0.92
altair processInactivityUpdates - 250000 worstcase 27.957 ms/op 26.550 ms/op 1.05
phase0 processRegistryUpdates - 250000 normalcase 7.3930 us/op 8.6580 us/op 0.85
phase0 processRegistryUpdates - 250000 badcase_full_deposits 274.46 us/op 308.54 us/op 0.89
phase0 processRegistryUpdates - 250000 worstcase 0.5 133.25 ms/op 136.59 ms/op 0.98
altair processRewardsAndPenalties - 250000 normalcase 64.895 ms/op 72.651 ms/op 0.89
altair processRewardsAndPenalties - 250000 worstcase 71.139 ms/op 78.477 ms/op 0.91
phase0 getAttestationDeltas - 250000 normalcase 8.3002 ms/op 8.1412 ms/op 1.02
phase0 getAttestationDeltas - 250000 worstcase 7.2575 ms/op 7.1905 ms/op 1.01
phase0 processSlashings - 250000 worstcase 3.7265 ms/op 3.7932 ms/op 0.98
altair processSyncCommitteeUpdates - 250000 185.67 ms/op 206.91 ms/op 0.90
BeaconState.hashTreeRoot - No change 354.00 ns/op 286.00 ns/op 1.24
BeaconState.hashTreeRoot - 1 full validator 54.786 us/op 60.488 us/op 0.91
BeaconState.hashTreeRoot - 32 full validator 538.61 us/op 550.57 us/op 0.98
BeaconState.hashTreeRoot - 512 full validator 5.5932 ms/op 6.0805 ms/op 0.92
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 68.760 us/op 72.791 us/op 0.94
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 907.68 us/op 1.0236 ms/op 0.89
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.901 ms/op 16.653 ms/op 0.77
BeaconState.hashTreeRoot - 1 balances 53.961 us/op 56.707 us/op 0.95
BeaconState.hashTreeRoot - 32 balances 491.08 us/op 497.97 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 4.8511 ms/op 5.3809 ms/op 0.90
BeaconState.hashTreeRoot - 250000 balances 80.402 ms/op 84.618 ms/op 0.95
aggregationBits - 2048 els - zipIndexesInBitList 17.793 us/op 26.695 us/op 0.67
regular array get 100000 times 36.763 us/op 35.248 us/op 1.04
wrappedArray get 100000 times 43.083 us/op 34.737 us/op 1.24
arrayWithProxy get 100000 times 16.670 ms/op 16.871 ms/op 0.99
ssz.Root.equals 640.00 ns/op 676.00 ns/op 0.95
byteArrayEquals 619.00 ns/op 625.00 ns/op 0.99
shuffle list - 16384 els 7.5366 ms/op 7.1752 ms/op 1.05
shuffle list - 250000 els 107.00 ms/op 105.35 ms/op 1.02
processSlot - 1 slots 9.8830 us/op 10.248 us/op 0.96
processSlot - 32 slots 1.4813 ms/op 1.4447 ms/op 1.03
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 37.662 ms/op 41.442 ms/op 0.91
getCommitteeAssignments - req 1 vs - 250000 vc 3.1564 ms/op 3.1291 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 4.3259 ms/op 4.4472 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 4.8365 ms/op 5.1463 ms/op 0.94
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.3700 ns/op 6.0100 ns/op 0.89
state getBlockRootAtSlot - 250000 vs - 7PWei 939.19 ns/op 798.60 ns/op 1.18
computeProposers - vc 250000 11.515 ms/op 11.582 ms/op 0.99
computeEpochShuffling - vc 250000 117.14 ms/op 124.90 ms/op 0.94
getNextSyncCommittee - vc 250000 195.40 ms/op 200.33 ms/op 0.98
computeSigningRoot for AttestationData 15.656 us/op 16.590 us/op 0.94
hash AttestationData serialized data then Buffer.toString(base64) 2.6488 us/op 2.6370 us/op 1.00
toHexString serialized data 1.4255 us/op 1.7403 us/op 0.82
Buffer.toString(base64) 395.96 ns/op 403.62 ns/op 0.98

by benchmarkbot/action

@twoeths twoeths merged commit 6638ea7 into unstable Jun 26, 2023
@twoeths twoeths deleted the tuyen/fix_node_sync_has_fallen_behind branch June 26, 2023 14:29
@philknows philknows added this to the v1.9.1 milestone Jun 28, 2023
philknows pushed a commit that referenced this pull request Jun 28, 2023
@twoeths @philknows
fix: do not warn out-of-synced status at start up (#5708)
a66b6c0
@philknows philknows mentioned this pull request Jun 28, 2023
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.1 🎉

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.

[v1.9.0] Node sync has fallen behind by x slots
4 participants
@twoeths @wemeetagain @nflaig @philknows