Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace lerna commands with yarn #5657

Merged
merged 2 commits into from
Jun 16, 2023
Merged

chore: replace lerna commands with yarn #5657

merged 2 commits into from
Jun 16, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 16, 2023

Motivation

Referencing both lerna and yarn commands just creates confusion. Lerna is also not a prerequisite of the project as it is installed as dev dependency.

Description

  • Removes lerna from prerequisities, instead adds nodejs if not already mentioned
  • Replaces lerna commands with yarn

@nflaig nflaig requested a review from a team as a code owner June 16, 2023 09:41
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 7f56018 Previous: 2eddf46 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 622.61 us/op 850.54 us/op 0.73
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 52.179 us/op 44.354 us/op 1.18
BLS verify - blst-native 1.2586 ms/op 1.1745 ms/op 1.07
BLS verifyMultipleSignatures 3 - blst-native 2.5790 ms/op 2.3857 ms/op 1.08
BLS verifyMultipleSignatures 8 - blst-native 5.5176 ms/op 5.1394 ms/op 1.07
BLS verifyMultipleSignatures 32 - blst-native 19.955 ms/op 19.456 ms/op 1.03
BLS aggregatePubkeys 32 - blst-native 26.775 us/op 25.369 us/op 1.06
BLS aggregatePubkeys 128 - blst-native 105.12 us/op 99.430 us/op 1.06
getAttestationsForBlock 61.966 ms/op 66.760 ms/op 0.93
isKnown best case - 1 super set check 279.00 ns/op 262.00 ns/op 1.06
isKnown normal case - 2 super set checks 269.00 ns/op 260.00 ns/op 1.03
isKnown worse case - 16 super set checks 268.00 ns/op 260.00 ns/op 1.03
CheckpointStateCache - add get delete 5.6370 us/op 4.8280 us/op 1.17
validate gossip signedAggregateAndProof - struct 2.9125 ms/op 2.6676 ms/op 1.09
validate gossip attestation - struct 1.3801 ms/op 1.2732 ms/op 1.08
pickEth1Vote - no votes 1.3932 ms/op 1.2691 ms/op 1.10
pickEth1Vote - max votes 11.642 ms/op 12.759 ms/op 0.91
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.8316 ms/op 9.2379 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 16.154 ms/op 17.465 ms/op 0.92
pickEth1Vote - Eth1Data fastSerialize value x2048 758.08 us/op 639.20 us/op 1.19
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.9903 ms/op 8.8463 ms/op 0.90
bytes32 toHexString 728.00 ns/op 479.00 ns/op 1.52
bytes32 Buffer.toString(hex) 438.00 ns/op 348.00 ns/op 1.26
bytes32 Buffer.toString(hex) from Uint8Array 613.00 ns/op 561.00 ns/op 1.09
bytes32 Buffer.toString(hex) + 0x 411.00 ns/op 354.00 ns/op 1.16
Object access 1 prop 0.20200 ns/op 0.17000 ns/op 1.19
Map access 1 prop 0.16800 ns/op 0.16100 ns/op 1.04
Object get x1000 6.9760 ns/op 7.5530 ns/op 0.92
Map get x1000 0.66800 ns/op 0.60200 ns/op 1.11
Object set x1000 74.093 ns/op 53.201 ns/op 1.39
Map set x1000 58.811 ns/op 42.969 ns/op 1.37
Return object 10000 times 0.25190 ns/op 0.24100 ns/op 1.05
Throw Error 10000 times 4.4550 us/op 4.3022 us/op 1.04
fastMsgIdFn sha256 / 200 bytes 3.6990 us/op 3.4630 us/op 1.07
fastMsgIdFn h32 xxhash / 200 bytes 325.00 ns/op 301.00 ns/op 1.08
fastMsgIdFn h64 xxhash / 200 bytes 476.00 ns/op 420.00 ns/op 1.13
fastMsgIdFn sha256 / 1000 bytes 12.328 us/op 11.604 us/op 1.06
fastMsgIdFn h32 xxhash / 1000 bytes 466.00 ns/op 425.00 ns/op 1.10
fastMsgIdFn h64 xxhash / 1000 bytes 566.00 ns/op 481.00 ns/op 1.18
fastMsgIdFn sha256 / 10000 bytes 109.11 us/op 104.15 us/op 1.05
fastMsgIdFn h32 xxhash / 10000 bytes 2.0440 us/op 1.9120 us/op 1.07
fastMsgIdFn h64 xxhash / 10000 bytes 1.4760 us/op 1.3530 us/op 1.09
enrSubnets - fastDeserialize 64 bits 1.7560 us/op 1.3380 us/op 1.31
enrSubnets - ssz BitVector 64 bits 642.00 ns/op 495.00 ns/op 1.30
enrSubnets - fastDeserialize 4 bits 216.00 ns/op 178.00 ns/op 1.21
enrSubnets - ssz BitVector 4 bits 605.00 ns/op 499.00 ns/op 1.21
prioritizePeers score -10:0 att 32-0.1 sync 2-0 120.73 us/op 109.11 us/op 1.11
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 160.23 us/op 130.15 us/op 1.23
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 193.34 us/op 164.83 us/op 1.17
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 359.24 us/op 295.94 us/op 1.21
prioritizePeers score 0:0 att 64-1 sync 4-1 426.90 us/op 354.25 us/op 1.21
array of 16000 items push then shift 1.7171 us/op 1.6110 us/op 1.07
LinkedList of 16000 items push then shift 9.3630 ns/op 8.7890 ns/op 1.07
array of 16000 items push then pop 113.56 ns/op 78.875 ns/op 1.44
LinkedList of 16000 items push then pop 9.0870 ns/op 8.5310 ns/op 1.07
array of 24000 items push then shift 2.4131 us/op 2.3450 us/op 1.03
LinkedList of 24000 items push then shift 9.6180 ns/op 10.293 ns/op 0.93
array of 24000 items push then pop 89.825 ns/op 75.984 ns/op 1.18
LinkedList of 24000 items push then pop 9.2100 ns/op 8.6690 ns/op 1.06
intersect bitArray bitLen 8 14.438 ns/op 13.226 ns/op 1.09
intersect array and set length 8 89.246 ns/op 74.355 ns/op 1.20
intersect bitArray bitLen 128 45.657 ns/op 43.679 ns/op 1.05
intersect array and set length 128 1.1593 us/op 1.0252 us/op 1.13
Buffer.concat 32 items 3.1590 us/op 2.6640 us/op 1.19
Uint8Array.set 32 items 2.9140 us/op 2.6810 us/op 1.09
transfer serialized Status (84 B) 2.2230 us/op 2.1480 us/op 1.03
copy serialized Status (84 B) 1.8450 us/op 1.7690 us/op 1.04
transfer serialized SignedVoluntaryExit (112 B) 2.3580 us/op 2.1590 us/op 1.09
copy serialized SignedVoluntaryExit (112 B) 1.8540 us/op 1.8140 us/op 1.02
transfer serialized ProposerSlashing (416 B) 2.4060 us/op 2.8620 us/op 0.84
copy serialized ProposerSlashing (416 B) 2.2610 us/op 3.2370 us/op 0.70
transfer serialized Attestation (485 B) 2.4810 us/op 2.8660 us/op 0.87
copy serialized Attestation (485 B) 2.2790 us/op 3.4490 us/op 0.66
transfer serialized AttesterSlashing (33232 B) 2.7430 us/op 3.0920 us/op 0.89
copy serialized AttesterSlashing (33232 B) 8.2880 us/op 6.2370 us/op 1.33
transfer serialized Small SignedBeaconBlock (128000 B) 3.2030 us/op 2.9760 us/op 1.08
copy serialized Small SignedBeaconBlock (128000 B) 16.873 us/op 18.031 us/op 0.94
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2520 us/op 3.2790 us/op 0.99
copy serialized Avg SignedBeaconBlock (200000 B) 67.955 us/op 22.796 us/op 2.98
transfer serialized BlobsSidecar (524380 B) 3.5590 us/op 3.1480 us/op 1.13
copy serialized BlobsSidecar (524380 B) 183.27 us/op 151.59 us/op 1.21
transfer serialized Big SignedBeaconBlock (1000000 B) 3.6770 us/op 3.0010 us/op 1.23
copy serialized Big SignedBeaconBlock (1000000 B) 272.59 us/op 220.20 us/op 1.24
pass gossip attestations to forkchoice per slot 2.7322 ms/op 2.6524 ms/op 1.03
forkChoice updateHead vc 100000 bc 64 eq 0 2.1642 ms/op 2.0956 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 0 12.605 ms/op 12.859 ms/op 0.98
forkChoice updateHead vc 1000000 bc 64 eq 0 23.968 ms/op 18.653 ms/op 1.28
forkChoice updateHead vc 600000 bc 320 eq 0 17.787 ms/op 16.455 ms/op 1.08
forkChoice updateHead vc 600000 bc 1200 eq 0 87.694 ms/op 79.487 ms/op 1.10
forkChoice updateHead vc 600000 bc 64 eq 1000 21.567 ms/op 20.396 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 10000 23.095 ms/op 22.379 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 300000 32.713 ms/op 30.693 ms/op 1.07
computeDeltas 3.2992 ms/op 4.5179 ms/op 0.73
computeProposerBoostScoreFromBalances 1.8420 ms/op 1.7644 ms/op 1.04
altair processAttestation - 250000 vs - 7PWei normalcase 3.2542 ms/op 2.2429 ms/op 1.45
altair processAttestation - 250000 vs - 7PWei worstcase 4.8363 ms/op 3.5202 ms/op 1.37
altair processAttestation - setStatus - 1/6 committees join 144.09 us/op 133.31 us/op 1.08
altair processAttestation - setStatus - 1/3 committees join 286.44 us/op 257.71 us/op 1.11
altair processAttestation - setStatus - 1/2 committees join 378.73 us/op 356.38 us/op 1.06
altair processAttestation - setStatus - 2/3 committees join 477.03 us/op 455.59 us/op 1.05
altair processAttestation - setStatus - 4/5 committees join 675.34 us/op 609.70 us/op 1.11
altair processAttestation - setStatus - 100% committees join 789.19 us/op 716.60 us/op 1.10
altair processBlock - 250000 vs - 7PWei normalcase 16.999 ms/op 20.610 ms/op 0.82
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.409 ms/op 27.832 ms/op 1.02
altair processBlock - 250000 vs - 7PWei worstcase 49.835 ms/op 66.577 ms/op 0.75
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.257 ms/op 71.417 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 2.5959 ms/op 1.9438 ms/op 1.34
phase0 processBlock - 250000 vs - 7PWei worstcase 30.593 ms/op 28.240 ms/op 1.08
altair processEth1Data - 250000 vs - 7PWei normalcase 576.03 us/op 478.08 us/op 1.20
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.7080 us/op 6.6010 us/op 1.47
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 29.499 us/op 31.689 us/op 0.93
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 12.864 us/op 13.734 us/op 0.94
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.4860 us/op 10.245 us/op 0.93
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 114.35 us/op 74.279 us/op 1.54
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 669.76 us/op 1.2042 ms/op 0.56
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 941.25 us/op 1.6584 ms/op 0.57
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 926.09 us/op 1.6265 ms/op 0.57
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4789 ms/op 2.2506 ms/op 1.10
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5250 ms/op 2.3202 ms/op 0.66
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.5092 ms/op 3.7477 ms/op 1.20
Tree 40 250000 create 364.81 ms/op 296.73 ms/op 1.23
Tree 40 250000 get(125000) 200.20 ns/op 178.74 ns/op 1.12
Tree 40 250000 set(125000) 1.1106 us/op 929.40 ns/op 1.19
Tree 40 250000 toArray() 22.003 ms/op 17.313 ms/op 1.27
Tree 40 250000 iterate all - toArray() + loop 23.220 ms/op 17.148 ms/op 1.35
Tree 40 250000 iterate all - get(i) 77.343 ms/op 67.446 ms/op 1.15
MutableVector 250000 create 11.686 ms/op 14.911 ms/op 0.78
MutableVector 250000 get(125000) 6.7360 ns/op 6.2780 ns/op 1.07
MutableVector 250000 set(125000) 313.76 ns/op 245.64 ns/op 1.28
MutableVector 250000 toArray() 4.1557 ms/op 2.7455 ms/op 1.51
MutableVector 250000 iterate all - toArray() + loop 4.2356 ms/op 2.8332 ms/op 1.49
MutableVector 250000 iterate all - get(i) 1.6198 ms/op 1.4634 ms/op 1.11
Array 250000 create 3.6190 ms/op 2.5919 ms/op 1.40
Array 250000 clone - spread 1.2222 ms/op 1.2637 ms/op 0.97
Array 250000 get(125000) 0.59700 ns/op 0.60500 ns/op 0.99
Array 250000 set(125000) 0.64500 ns/op 0.67700 ns/op 0.95
Array 250000 iterate all - loop 85.901 us/op 86.509 us/op 0.99
effectiveBalanceIncrements clone Uint8Array 300000 41.549 us/op 28.915 us/op 1.44
effectiveBalanceIncrements clone MutableVector 300000 345.00 ns/op 405.00 ns/op 0.85
effectiveBalanceIncrements rw all Uint8Array 300000 174.29 us/op 166.50 us/op 1.05
effectiveBalanceIncrements rw all MutableVector 300000 89.575 ms/op 80.884 ms/op 1.11
phase0 afterProcessEpoch - 250000 vs - 7PWei 119.27 ms/op 119.35 ms/op 1.00
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.592 ms/op 45.406 ms/op 0.96
altair processEpoch - mainnet_e81889 345.74 ms/op 374.59 ms/op 0.92
mainnet_e81889 - altair beforeProcessEpoch 68.989 ms/op 69.405 ms/op 0.99
mainnet_e81889 - altair processJustificationAndFinalization 18.896 us/op 27.746 us/op 0.68
mainnet_e81889 - altair processInactivityUpdates 6.6907 ms/op 5.9252 ms/op 1.13
mainnet_e81889 - altair processRewardsAndPenalties 69.756 ms/op 88.229 ms/op 0.79
mainnet_e81889 - altair processRegistryUpdates 2.4840 us/op 4.4850 us/op 0.55
mainnet_e81889 - altair processSlashings 680.00 ns/op 774.00 ns/op 0.88
mainnet_e81889 - altair processEth1DataReset 653.00 ns/op 891.00 ns/op 0.73
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.1164 ms/op 2.2880 ms/op 0.92
mainnet_e81889 - altair processSlashingsReset 4.7740 us/op 6.5150 us/op 0.73
mainnet_e81889 - altair processRandaoMixesReset 8.2350 us/op 9.9470 us/op 0.83
mainnet_e81889 - altair processHistoricalRootsUpdate 940.00 ns/op 1.3150 us/op 0.71
mainnet_e81889 - altair processParticipationFlagUpdates 3.0300 us/op 3.2260 us/op 0.94
mainnet_e81889 - altair processSyncCommitteeUpdates 572.00 ns/op 1.0330 us/op 0.55
mainnet_e81889 - altair afterProcessEpoch 132.40 ms/op 127.62 ms/op 1.04
phase0 processEpoch - mainnet_e58758 373.72 ms/op 413.76 ms/op 0.90
mainnet_e58758 - phase0 beforeProcessEpoch 147.84 ms/op 170.69 ms/op 0.87
mainnet_e58758 - phase0 processJustificationAndFinalization 17.125 us/op 26.962 us/op 0.64
mainnet_e58758 - phase0 processRewardsAndPenalties 66.180 ms/op 78.479 ms/op 0.84
mainnet_e58758 - phase0 processRegistryUpdates 10.360 us/op 7.8550 us/op 1.32
mainnet_e58758 - phase0 processSlashings 582.00 ns/op 812.00 ns/op 0.72
mainnet_e58758 - phase0 processEth1DataReset 713.00 ns/op 940.00 ns/op 0.76
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1070 ms/op 1.8909 ms/op 0.59
mainnet_e58758 - phase0 processSlashingsReset 4.9550 us/op 6.5680 us/op 0.75
mainnet_e58758 - phase0 processRandaoMixesReset 5.1930 us/op 7.4240 us/op 0.70
mainnet_e58758 - phase0 processHistoricalRootsUpdate 969.00 ns/op 1.2150 us/op 0.80
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.6510 us/op 6.6750 us/op 0.85
mainnet_e58758 - phase0 afterProcessEpoch 102.21 ms/op 95.219 ms/op 1.07
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2931 ms/op 2.2778 ms/op 0.57
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5510 ms/op 2.9434 ms/op 0.53
altair processInactivityUpdates - 250000 normalcase 24.773 ms/op 30.639 ms/op 0.81
altair processInactivityUpdates - 250000 worstcase 26.369 ms/op 30.801 ms/op 0.86
phase0 processRegistryUpdates - 250000 normalcase 8.4070 us/op 10.940 us/op 0.77
phase0 processRegistryUpdates - 250000 badcase_full_deposits 309.12 us/op 462.60 us/op 0.67
phase0 processRegistryUpdates - 250000 worstcase 0.5 111.74 ms/op 149.05 ms/op 0.75
altair processRewardsAndPenalties - 250000 normalcase 69.822 ms/op 75.059 ms/op 0.93
altair processRewardsAndPenalties - 250000 worstcase 71.231 ms/op 70.135 ms/op 1.02
phase0 getAttestationDeltas - 250000 normalcase 7.2148 ms/op 6.6639 ms/op 1.08
phase0 getAttestationDeltas - 250000 worstcase 7.0220 ms/op 6.5682 ms/op 1.07
phase0 processSlashings - 250000 worstcase 3.5915 ms/op 3.4575 ms/op 1.04
altair processSyncCommitteeUpdates - 250000 191.07 ms/op 184.82 ms/op 1.03
BeaconState.hashTreeRoot - No change 326.00 ns/op 266.00 ns/op 1.23
BeaconState.hashTreeRoot - 1 full validator 55.365 us/op 68.143 us/op 0.81
BeaconState.hashTreeRoot - 32 full validator 563.30 us/op 620.50 us/op 0.91
BeaconState.hashTreeRoot - 512 full validator 6.0276 ms/op 6.5059 ms/op 0.93
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 68.048 us/op 64.573 us/op 1.05
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 997.54 us/op 1.1888 ms/op 0.84
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.482 ms/op 12.051 ms/op 1.04
BeaconState.hashTreeRoot - 1 balances 54.542 us/op 57.647 us/op 0.95
BeaconState.hashTreeRoot - 32 balances 479.44 us/op 439.86 us/op 1.09
BeaconState.hashTreeRoot - 512 balances 4.8616 ms/op 4.7199 ms/op 1.03
BeaconState.hashTreeRoot - 250000 balances 75.598 ms/op 80.426 ms/op 0.94
aggregationBits - 2048 els - zipIndexesInBitList 17.975 us/op 15.443 us/op 1.16
regular array get 100000 times 46.137 us/op 32.593 us/op 1.42
wrappedArray get 100000 times 36.558 us/op 32.777 us/op 1.12
arrayWithProxy get 100000 times 17.817 ms/op 15.388 ms/op 1.16
ssz.Root.equals 635.00 ns/op 540.00 ns/op 1.18
byteArrayEquals 649.00 ns/op 534.00 ns/op 1.22
shuffle list - 16384 els 7.4325 ms/op 6.8728 ms/op 1.08
shuffle list - 250000 els 109.20 ms/op 100.68 ms/op 1.08
processSlot - 1 slots 9.3900 us/op 9.4040 us/op 1.00
processSlot - 32 slots 1.4911 ms/op 1.2545 ms/op 1.19
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 37.698 ms/op 40.121 ms/op 0.94
getCommitteeAssignments - req 1 vs - 250000 vc 3.0494 ms/op 2.8930 ms/op 1.05
getCommitteeAssignments - req 100 vs - 250000 vc 4.2787 ms/op 4.1144 ms/op 1.04
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6829 ms/op 4.6054 ms/op 1.02
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.0300 ns/op 4.5800 ns/op 1.10
state getBlockRootAtSlot - 250000 vs - 7PWei 671.23 ns/op 610.74 ns/op 1.10
computeProposers - vc 250000 11.712 ms/op 10.399 ms/op 1.13
computeEpochShuffling - vc 250000 110.60 ms/op 102.87 ms/op 1.08
getNextSyncCommittee - vc 250000 194.21 ms/op 170.13 ms/op 1.14
computeSigningRoot for AttestationData 15.322 us/op 13.101 us/op 1.17
hash AttestationData serialized data then Buffer.toString(base64) 2.6120 us/op 2.4316 us/op 1.07
toHexString serialized data 1.3076 us/op 1.0594 us/op 1.23
Buffer.toString(base64) 370.23 ns/op 314.65 ns/op 1.18

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 83d1b7c into unstable Jun 16, 2023
@wemeetagain wemeetagain deleted the nflaig/replace-lerna-cmds-with-yarn branch June 16, 2023 14:58
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain