Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unmet peer dependencies #5469

Merged
merged 4 commits into from
May 8, 2023
Merged

chore: remove unmet peer dependencies #5469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c22c03e
Remove fastify as peer dep from api package
nflaig May 8, 2023
570b8db
Ensure fastify is only used as type
nflaig May 8, 2023
97aca68
Remove c-kzg as peer dep from beacon-node package
nflaig May 8, 2023
83ac15b
Update reqresp libp2p version to match beacon-node version
nflaig May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@
"ajv": "^8.12.0",
"fastify": "^4.15.0"
},
"peerDependencies": {
"fastify": "^4.15.0"
Copy link
Member Author

@nflaig nflaig May 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only types are use in this package, there is a warning because validator package does not install fastify and neither should it, as it has to be browser compatible

},
"keywords": [
"ethereum",
"eth-consensus",
Expand Down
4 changes: 2 additions & 2 deletions packages/api/src/utils/server/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// eslint-disable-next-line import/no-extraneous-dependencies
import {FastifyInstance} from "fastify";
import type {FastifyInstance} from "fastify";
// eslint-disable-next-line import/no-extraneous-dependencies
import * as fastify from "fastify";
import type * as fastify from "fastify";
import {ReqGeneric} from "../types.js";

export type ServerInstance = FastifyInstance;
Expand Down
3 changes: 0 additions & 3 deletions packages/beacon-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@
"varint": "^6.0.0",
"xxhash-wasm": "1.0.2"
},
"peerDependencies": {
"c-kzg": "^1.0.7"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c-kzg is already installed as dependency, shouldn't make a difference if this line is removed

lodestar/packages/beacon-node/package.json

Line 136 in ff64d4b

"c-kzg": "^1.0.9",

},
"devDependencies": {
"@types/eventsource": "^1.1.11",
"@types/leveldown": "^4.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/reqresp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@lodestar/types": "^1.8.0"
},
"peerDependencies": {
"libp2p": "0.41.0"
"libp2p": "~0.42.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the warning if beacon-node package is installed, however top-level install still shows a warning, not sure how to get rid of that, might be related to

Checked peer deps via check-peer-dependencies, looks mostly correct now

},
"keywords": [
"ethereum",
Expand Down