-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(reqresp)!: support byte based handlers #5417
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
Regarding the PR title, if a change is specific to a package, we could use the package name as scope e.g. |
Pushed a significant refactor to align this to what is eventually needed to work within a worker thread. We really need to have this asap so please review correctness and not organizational approaches that we can review latter after landing the worker thread issue |
0c646bd
to
e580c48
Compare
3bc9875
to
e6d47ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this looks good to me, there's a typo and a question about the rate limiter change
b3c0c0e
to
0f3ddce
Compare
🎉 This PR is included in v1.9.0 🎉 |
Motivation
Update
reqresp
package to only support thebytes
for handler.Description
To make
network
more flexible to work form the worker, need to make the reqresp more consistent.Closes #5378
Steps to test or reproduce