-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable arm64 docker build #3734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
requested review from
dapplion,
g11tech,
mpetrunic and
twoeths
as code owners
February 8, 2022 17:35
Codecov Report
@@ Coverage Diff @@
## master #3734 +/- ##
=======================================
Coverage 37.14% 37.14%
=======================================
Files 320 320
Lines 8722 8722
Branches 1356 1356
=======================================
Hits 3240 3240
Misses 5340 5340
Partials 142 142 |
Performance Report✔️ no performance regression detected Full benchmark results
|
@wemeetagain For next attempts you can modify the github actions workflow to also trigger on a specific branch temporarily to prevent polluting master |
dapplion
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://github.com/ChainSafe/lodestar/runs/5113003430?check_suite_focus=true
and
ChainSafe/blst-ts#51
After #3698 , the docker build is breaking because blst isn't prebuilt for arm64, and the final docker layer doesn't have build tools to build blst itself.
We should first resolve ChainSafe/blst-ts#51, then revert this when we're ready.
Description
Quick way to resolve the currently breaking docker build, just don't build the arm64 image.