-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge fork transition process #3197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
September 16, 2021 20:10
Code Climate has analyzed commit c4d23f4 and detected 0 issues on this pull request. View more on Code Climate. |
dapplion
force-pushed
the
dapplion/merge-fork
branch
from
September 16, 2021 20:11
5c70de1
to
57f0b55
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
@@ Coverage Diff @@
## master #3197 +/- ##
==========================================
- Coverage 58.42% 58.40% -0.03%
==========================================
Files 375 376 +1
Lines 9176 9198 +22
Branches 1360 1366 +6
==========================================
+ Hits 5361 5372 +11
- Misses 3432 3444 +12
+ Partials 383 382 -1 |
wemeetagain
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #3076
Incomplete work until the mechanism to decide total terminal difficulty is clarified. Follow ethereum/consensus-specs#2603
Description
Closes #3196