Enforce no relative package imports

.eslintrc.js

@@ -102,6 +102,7 @@ module.exports = {
     "func-call-spacing": "off",
     //if --fix is run it messes imports like /lib/presets/minimal & /lib/presets/mainnet
     "import/no-duplicates": "off",
+    "import/no-relative-packages": "error",
     "node/no-deprecated-api": "error",
     "new-parens": "error",
     "no-caller": "error",

package.json

@@ -56,7 +56,7 @@
     "codecov": "^3.6.5",
     "concurrently": "^5.3.0",
     "eslint": "^7.14.0",
-    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-import": "^2.23.0",
     "eslint-plugin-no-only-tests": "^2.4.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^3.1.4",

packages/lodestar/test/perf/chain/opPools/aggregatedAttestationPool.test.ts

@@ -9,7 +9,7 @@ import {AggregatedAttestationPool} from "../../../../src/chain/opPools/aggregate
 import {SLOTS_PER_EPOCH} from "@chainsafe/lodestar-params";
 import {List} from "@chainsafe/ssz";
 import {profilerLogger} from "@chainsafe/lodestar-beacon-state-transition/test/utils/logger";
-import {generatePerfTestCachedStateAltair} from "../../../../../beacon-state-transition/test/perf/util";
+import {generatePerfTestCachedStateAltair} from "@chainsafe/lodestar-beacon-state-transition/test/perf/util";
 
 // Jul-21 09:20:46.653 []                 info: Number of participations in state previousEpoch=250000, currentEpoch=250000
 // Jul-21 09:23:38.382 []                 info: Number of attestations in pool 1952

packages/lodestar/test/perf/chain/stateCache/stateContextCheckpointsCache.test.ts

@@ -1,13 +1,12 @@
 import {itBench, setBenchOpts} from "@dapplion/benchmark";
 import {CachedBeaconState} from "@chainsafe/lodestar-beacon-state-transition";
-import {allForks, ssz} from "@chainsafe/lodestar-types";
+import {allForks, ssz, phase0} from "@chainsafe/lodestar-types";
 import {generateCachedState} from "../../../utils/state";
 import {CheckpointStateCache} from "../../../../src/chain/stateCache";
-import {Checkpoint} from "../../../../../types/phase0";
 
 describe.skip("CheckpointStateCache perf tests", function () {
   let state: CachedBeaconState<allForks.BeaconState>;
-  let checkpoint: Checkpoint;
+  let checkpoint: phase0.Checkpoint;
   let checkpointStateCache: CheckpointStateCache;
 
   setBenchOpts({

packages/lodestar/test/unit/chain/opPools/aggregatedAttestationPool.test.ts

@@ -4,7 +4,7 @@ import {createIChainForkConfig, defaultChainConfig} from "@chainsafe/lodestar-co
 import {SLOTS_PER_EPOCH} from "@chainsafe/lodestar-params";
 import {List} from "@chainsafe/ssz";
 import {expect} from "chai";
-import {ssz} from "../../../../../types/lib/phase0";
+import {ssz, phase0} from "@chainsafe/lodestar-types";
 import {
   AggregatedAttestationPool,
   aggregateInto,
@@ -17,7 +17,6 @@ import {generateCachedState} from "../../../utils/state";
 import * as attestationUtils from "@chainsafe/lodestar-beacon-state-transition/lib/phase0/block/processAttestation";
 import {SinonStubFn} from "../../../utils/types";
 import sinon from "sinon";
-import {phase0} from "../../../../../types/lib";
 
 describe("AggregatedAttestationPool", function () {
   let pool: AggregatedAttestationPool;
@@ -62,7 +61,7 @@ describe("MatchingDataAttestationGroup", function () {
   let attestationGroup: MatchingDataAttestationGroup;
   const committee = [100, 200, 300];
   const attestationSeed = generateEmptyAttestation();
-  const attestationDataRoot = ssz.AttestationData.serialize(attestationSeed.data);
+  const attestationDataRoot = ssz.phase0.AttestationData.serialize(attestationSeed.data);
   let sk1: SecretKey;
   const attestation1 = {...attestationSeed, ...{aggregationBits: [true, true, false] as List<boolean>}};
 
@@ -175,7 +174,7 @@ describe("aggregateInto", function () {
   const attestationSeed = generateEmptyAttestation();
   const attestation1 = {...attestationSeed, ...{aggregationBits: [false, true] as List<boolean>}};
   const attestation2 = {...attestationSeed, ...{aggregationBits: [true, false] as List<boolean>}};
-  const attestationDataRoot = ssz.AttestationData.serialize(attestationSeed.data);
+  const attestationDataRoot = ssz.phase0.AttestationData.serialize(attestationSeed.data);
   let sk1: SecretKey;
   let sk2: SecretKey;
   before("Init BLS", async () => {

packages/validator/src/slashingProtection/types.ts

@@ -1,4 +1,4 @@
-import {Epoch, Root, Slot} from "../../../types/phase0";
+import {Epoch, Root, Slot} from "@chainsafe/lodestar-types";
 
 /* eslint-disable @typescript-eslint/naming-convention */