test: fix the benchmark tests (#6160)

* Update the number of validators * Run the benchmark workflow manually * Add comments explaining the function side effects
ChainSafe · Dec 6, 2023 · f8d3ab0 · f8d3ab0
1 parent 836fabf
commit f8d3ab0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -17,6 +17,7 @@ on:
     branches:
       - stable
       - unstable
+  workflow_dispatch:
 
 jobs:
   run:

diff --git a/packages/beacon-node/test/perf/chain/produceBlock/produceBlockBody.test.ts b/packages/beacon-node/test/perf/chain/produceBlock/produceBlockBody.test.ts
@@ -15,10 +15,9 @@ import {BeaconDb} from "../../../../src/index.js";
 import {testLogger} from "../../../utils/logger.js";
 
 const logger = testLogger();
-const numberOfValidators = 1024;
 
 describe("produceBlockBody", () => {
-  const stateOg = generatePerfTestCachedStateAltair({goBackOneSlot: false, vc: numberOfValidators});
+  const stateOg = generatePerfTestCachedStateAltair({goBackOneSlot: false});
 
   let db: BeaconDb;
   let chain: BeaconChain;

diff --git a/packages/state-transition/test/perf/util.ts b/packages/state-transition/test/perf/util.ts
@@ -211,6 +211,10 @@ export function cachedStateAltairPopulateCaches(state: CachedBeaconStateAltair):
   state.inactivityScores.getAll();
 }
 
+/**
+ * Warning: This function has side effects on the cached state
+ * The order in which the caches are populated is important and can cause stable tests to fail.
+ */
 export function generatePerfTestCachedStateAltair(opts?: {
   goBackOneSlot: boolean;
   vc?: number;