add todo for pre-emptive block/blobs pull

ChainSafe · Aug 6, 2023 · 3fd6b2f · 3fd6b2f
1 parent fcbbf02
commit 3fd6b2f
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/packages/beacon-node/src/network/processor/gossipHandlers.ts b/packages/beacon-node/src/network/processor/gossipHandlers.ts
@@ -254,6 +254,12 @@ export function getGossipHandlers(modules: ValidatorFnsModules, options: GossipH
       );
       if (blockInput !== null) {
         handleValidBeaconBlock(blockInput, peerIdStr, seenTimestampSec);
+      } else {
+        // TODO DENEB:
+        //
+        // If block + blobs not fully recieved in the slot within some deadline, we should trigger block/blob
+        // pull using req/resp by root pre-emptively even though it will be trigged on seeing any block/blob
+        // gossip on next slot via missing parent checks
       }
     },
 
@@ -265,6 +271,12 @@ export function getGossipHandlers(modules: ValidatorFnsModules, options: GossipH
       const blockInput = await validateBeaconBlob(signedBlob, serializedData, topic.index, peerIdStr, seenTimestampSec);
       if (blockInput !== null) {
         handleValidBeaconBlock(blockInput, peerIdStr, seenTimestampSec);
+      } else {
+        // TODO DENEB:
+        //
+        // If block + blobs not fully recieved in the slot within some deadline, we should trigger block/blob
+        // pull using req/resp by root pre-emptively even though it will be trigged on seeing any block/blob
+        // gossip on next slot via missing parent checks
       }
     },