fix: effectiveBalanceLimit should be per validator

ChainSafe · Aug 23, 2024 · 12296dc · 12296dc
1 parent eeaefc1
commit 12296dc
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/packages/state-transition/src/epoch/processEffectiveBalanceUpdates.ts b/packages/state-transition/src/epoch/processEffectiveBalanceUpdates.ts
@@ -47,10 +47,6 @@ export function processEffectiveBalanceUpdates(
   const balances = cache.balances ?? state.balances.getAll();
   const currentEpochValidators = cache.validators;
   const newCompoundingValidators = cache.newCompoundingValidators ?? new Set();
-  let effectiveBalanceLimit: number | null = null;
-  if (fork < ForkSeq.electra) {
-    effectiveBalanceLimit = MAX_EFFECTIVE_BALANCE;
-  }
 
   let numUpdate = 0;
   for (let i = 0, len = balances.length; i < len; i++) {
@@ -60,8 +56,11 @@ export function processEffectiveBalanceUpdates(
     let effectiveBalanceIncrement = effectiveBalanceIncrements[i];
     let effectiveBalance = effectiveBalanceIncrement * EFFECTIVE_BALANCE_INCREMENT;
 
-    // from electra
-    if (effectiveBalanceLimit === null) {
+    let effectiveBalanceLimit: number;
+    if (fork < ForkSeq.electra) {
+      effectiveBalanceLimit = MAX_EFFECTIVE_BALANCE;
+    } else {
+      // from electra, effectiveBalanceLimit is per validator
       const isCompoundingValidator =
         hasCompoundingWithdrawalCredential(currentEpochValidators[i].withdrawalCredentials) ||
         newCompoundingValidators.has(i);