Open
Conversation
nflaig
reviewed
Dec 2, 2024
|
|
||
| LODESTAR_IMAGE=chainsafe/lodestar:next | ||
|
|
||
| LODESTAR_HEAP=16384 |
Member
There was a problem hiding this comment.
this should not be required to be higher in nft testnets since we fixed the issue that caused the memory increase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What about using a variable like
LODESTAR_HEAP(or similar) for this? that way could already set a default of16384in .vars file for non-finality devnets. And if var is not set just default to8192Originally posted by @nflaig in #58 (comment)
This PR enables this feature request and adjusts all *.vars network configs to set the variable.