fix: Add peer id str to mismatch error

[dapplion]

• Provide more context to debug mismatch instances like Peer ID doesn't match libp2p public key lodestar#4355

BEGIN_COMMIT_OVERRIDE
fix: Add peer id str to mismatch error
END_COMMIT_OVERRIDE

[mpetrunic]

@dapplion Could you update test case expected error message^^

[wemeetagain]

Really dislike tests like this, that check against specific string literals. Prone to breaking on updates and not much value add there.
Would be in favor of using CodeError and refactoring the test to check the err.code.

[dapplion]

Cannot run tests locally, currently stuck building the library with

[21:35:54] tsc [started]
error TS2688: Cannot find type definition file for 'keyv'.
  The file is in the program because:
    Entry point for implicit type library 'keyv'


Found 1 error.

[21:35:55] tsc [failed]
[21:35:55] → Command failed with exit code 1: tsc

[mpetrunic]

Cannot run tests locally, currently stuck building the library with

[21:35:54] tsc [started]
error TS2688: Cannot find type definition file for 'keyv'.
  The file is in the program because:
    Entry point for implicit type library 'keyv'


Found 1 error.

[21:35:55] tsc [failed]
[21:35:55] → Command failed with exit code 1: tsc

I cannot replicate that, have you tried deleting node_modules and package-lock.json?

[dapplion]

removing package-lock.json did not fix the issue, but removing node_modules did. Why? Can we please commit package-lock.json to all of our repos? The DX is terrible. We never have this types of issues in the Lodestar monorepo

[mpetrunic]

removing package-lock.json did not fix the issue, but removing node_modules did. Why? Can we please commit package-lock.json to all of our repos? The DX is terrible. We never have this types of issues in the Lodestar monorepo

Not 100%, but I think because it prefers to use the local version instead of the latest one.
Solution should not be to remove node_modules but to bump the package in package.json to minimum acceptable version.

Putting lockfiles in the repo would indeed resolve this problem for us but that could still happen to users of js-libp2p-noise in case some other package they use depends on a specific version that we find acceptable even though it isn't.

[mpetrunic]

keyv

In specific case, it cannot happen to the user as this is dev dependecy^^

Would be nice if there would be support to lockfile dev dependency only^^