Skip to content

fix: only increment nonce on valid messages #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: only increment nonce on valid messages #241

wants to merge 1 commit into from

Conversation

wemeetagain
Copy link
Member

See issue 2 here: GHSA-g9mp-8g3h-3c5c

@wemeetagain wemeetagain requested a review from a team as a code owner October 21, 2022 17:51
@mpetrunic
Copy link
Member

Already resolved via #200

@mpetrunic mpetrunic closed this Oct 24, 2022
@wemeetagain
Copy link
Member Author

lol i must have amnesia

@mpetrunic mpetrunic deleted the cayman/increment-valid branch October 24, 2022 15:13
@dapplion
Copy link
Contributor

If it's already resolved, how could @wemeetagain produce that code diff?

@wemeetagain
Copy link
Member Author

Seems I was based on an old commit (78921b9)

The fix is in and has been in
https://github.com/ChainSafe/js-libp2p-noise/blob/master/src/handshakes/abstract-handshake.ts#L26

@mpetrunic
Copy link
Member

I was laughing so hard when I have seen merge conflict between your new and old code 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wemeetagain @mpetrunic @dapplion