Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dot/parachain/backing): implement statement table method to drain missbehaviours #3996

Conversation

axaysagathiya
Copy link
Contributor

@axaysagathiya axaysagathiya commented Jun 1, 2024

Description

  • The statement table stores statements about candidates(parachain blocks) issued by authorities(parachain validators)
  • to call methods of statement table, we have an interface with a few methods, Which I am implementing one by one.
  • to know more about the statement table, read the description of issue feat(dot/parachain/backing): Implement Statement Table #3471
    • also, you can see it has a bunch of sub-issues, and this PR addresses one of them.

Changes

  • This PR implements a method to drain misbehaviour.
  • I changed the returned type of interface method to drain misbehaviours.
  • Written the unit test

Tests

go test ./dot/parachain/backing -run TestStatementTable_drainMisbehaviors

Issues

#3471

axaysagathiya and others added 29 commits May 4, 2024 23:17
…f github.com:ChainSafe/gossamer into axay/feat/backing/statement-table/attested-candidate
…nto axay/feat/backing/statement-table/import-statement
…o axay/feat/backing/statement-table/drain-misbehaviours
…github.com:ChainSafe/gossamer into axay/feat/backing/statement-table/import-statement
…o axay/feat/backing/statement-table/drain-misbehaviours
@axaysagathiya axaysagathiya marked this pull request as ready for review June 7, 2024 12:31
Copy link
Member

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

dot/parachain/backing/statement_table.go Show resolved Hide resolved
Base automatically changed from axay/feat/backing/statement-table/import-statement to feat/parachain June 10, 2024 09:35
…of github.com:ChainSafe/gossamer into axay/feat/backing/statement-table/drain-misbehaviours
@axaysagathiya axaysagathiya merged commit c35cb4e into feat/parachain Jun 13, 2024
21 checks passed
@axaysagathiya axaysagathiya deleted the axay/feat/backing/statement-table/drain-misbehaviours branch June 13, 2024 07:30
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
…n missbehaviours (#3996)

- This PR implements a method to drain misbehaviour.
- I changed the returned type of interface method to drain misbehaviours.
- Written the unit test
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
…n missbehaviours (#3996)

- This PR implements a method to drain misbehaviour.
- I changed the returned type of interface method to drain misbehaviours.
- Written the unit test
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
…n missbehaviours (#3996)

- This PR implements a method to drain misbehaviour.
- I changed the returned type of interface method to drain misbehaviours.
- Written the unit test
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
…n missbehaviours (#3996)

- This PR implements a method to drain misbehaviour.
- I changed the returned type of interface method to drain misbehaviours.
- Written the unit test
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
…n missbehaviours (#3996)

- This PR implements a method to drain misbehaviour.
- I changed the returned type of interface method to drain misbehaviours.
- Written the unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants