chore: add network integration test with kademilia instead mDNS #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1sar
added
S-network
P1sar
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
axaysagathiya
as code owners
jimjbrettj
reviewed
Mar 4, 2024
jimjbrettj
reviewed
Mar 4, 2024
|
nit/rename file to ./tests/network/network_integration_test.go |
jimjbrettj
reviewed
Mar 4, 2024
EclesioMeloJunior
requested changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While I was debugging network module I found out that our network tests using mDNS instead of Kademlia and so bypass or uses logic that is not actually used in Kademilia so I decided to implement integration test that covers producion code.
Tests
MODE=network go test ./tests/network/netwrok_integration_test.go -vgo test -tags integration github.com/ChainSafe/gossamerIssues
Related: #3758
Primary Reviewer
@