-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dot/parachain/backing): handle statement
message coming from overseer
#3532
Conversation
No, I will add them once I implement the entire subsystem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments and also made some changes. Please take a look them,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job!
I understand that this would have been quite challenging!! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @axaysagathiya 🎉
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
closes #3507
closes #3601
Primary Reviewer
@kishansagathiya @EclesioMeloJunior