Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): limit TestSync_Basic to 1 minute #2663

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jul 11, 2022

Changes

Otherwise it sometimes hangs forever retrying (i.e. when a node simply won't sync).
In that case, the test should just fail and move to the next one.

Quick-fix added after seeing https://github.com/ChainSafe/gossamer/runs/7281642432?check_suite_focus=true#step:3:32

Tests

go test -run ^TestSync_Basic$ github.com/ChainSafe/gossamer/tests/stress

Issues

Primary Reviewer

@timwu20

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2663 (379a84a) into development (8fd2188) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #2663      +/-   ##
===============================================
+ Coverage        62.96%   62.99%   +0.02%     
===============================================
  Files              211      211              
  Lines            27113    27113              
===============================================
+ Hits             17071    17079       +8     
+ Misses            8482     8476       -6     
+ Partials          1560     1558       -2     
Flag Coverage Δ
unit-tests 62.99% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/network/utils.go 58.33% <0.00%> (-1.93%) ⬇️
dot/network/connmgr.go 90.41% <0.00%> (+1.36%) ⬆️
dot/network/block_announce.go 63.20% <0.00%> (+4.80%) ⬆️
dot/network/inbound.go 100.00% <0.00%> (+7.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd2188...379a84a. Read the comment docs.

@qdm12 qdm12 merged commit 3a471d9 into development Jul 12, 2022
@qdm12 qdm12 deleted the qdm12/ci/limit-test-sync-basic-time branch July 12, 2022 13:59
@github-actions
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants