Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/babe): Unrestricted Loop When Building Blocks (GSR-19) #2632

Merged
merged 34 commits into from
Oct 6, 2022
Merged

fix(lib/babe): Unrestricted Loop When Building Blocks (GSR-19) #2632

merged 34 commits into from
Oct 6, 2022

Commits on Oct 6, 2022

  1. add test, add time.Sleep in loop

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    fdaadd6 View commit details
    Browse the repository at this point in the history

  2. add copyright notice

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    f2f05ed View commit details
    Browse the repository at this point in the history

  3. Channel based notification for queue Push

    @qdm12 @edwardmack
    qdm12 authored and edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e431b70 View commit details
    Browse the repository at this point in the history

  4. trying to add channel closed check

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a45be38 View commit details
    Browse the repository at this point in the history

  5. add check when creating channel

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4ef5e81 View commit details
    Browse the repository at this point in the history

  6. add check in Push func to check channel status

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4c70d07 View commit details
    Browse the repository at this point in the history

  7. address lint issues

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    02522a8 View commit details
    Browse the repository at this point in the history

  8. refactor test with nil pop result

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7c1add4 View commit details
    Browse the repository at this point in the history

  9. WIP, trying to make cancel channel for ticker

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    046eb19 View commit details
    Browse the repository at this point in the history

  10. address PR comments

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    bf7b414 View commit details
    Browse the repository at this point in the history

  11. formatting, remove newline

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4c336e2 View commit details
    Browse the repository at this point in the history

  12. WIP: add to tests

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    1121a3f View commit details
    Browse the repository at this point in the history

  13. wip

    @qdm12 @edwardmack
    qdm12 authored and edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    5837992 View commit details
    Browse the repository at this point in the history

  14. add to tests to increase coverage

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d0e52d3 View commit details
    Browse the repository at this point in the history

  15. add check for closed channel

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    35b8e1b View commit details
    Browse the repository at this point in the history

  16. remove nil assignment

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    f2321b4 View commit details
    Browse the repository at this point in the history

  17. remove flacky build unit tests, handled by integration tests

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    cf05044 View commit details
    Browse the repository at this point in the history

  18. remove test time channel, add intergration test

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    2fe32fe View commit details
    Browse the repository at this point in the history

  19. WIP - refactor test

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ded3520 View commit details
    Browse the repository at this point in the history

  20. updated integration test, increase coverage

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4b2343e View commit details
    Browse the repository at this point in the history

  21. WIP - implement transactionState.PopChannel

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ce546cf View commit details
    Browse the repository at this point in the history

  22. WIP - stub PopChannel2

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    6d96206 View commit details
    Browse the repository at this point in the history

  23. refactor use of pop channel

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    cf69b05 View commit details
    Browse the repository at this point in the history

  24. address linter issues, remove commented lines

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0ba0ae5 View commit details
    Browse the repository at this point in the history

  25. remove unused var

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d4c6bd6 View commit details
    Browse the repository at this point in the history

  26. add sleep to pop channel func

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    792253a View commit details
    Browse the repository at this point in the history

  27. refactor test to confirm priority

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    673a395 View commit details
    Browse the repository at this point in the history

  28. re-generate mocks

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7808743 View commit details
    Browse the repository at this point in the history

  29. introduce pop func to use pollTimer

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ee3664b View commit details
    Browse the repository at this point in the history

  30. PopChannel -> PopWithTimer 

    - Do not expose channel
- Remove hot for loop
- Update tests
- Use ticker instead of timer for polling
- Update comments
    @qdm12 @edwardmack
    qdm12 authored and edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    68195bc View commit details
    Browse the repository at this point in the history

  31. regenerate mocks

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    273258f View commit details
    Browse the repository at this point in the history

  32. add pop check, update pop with timer tests

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    c4ef178 View commit details
    Browse the repository at this point in the history

  33. pass time.Time channel to PopWithTimer, move test

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    438e4ca View commit details
    Browse the repository at this point in the history

  34. regenrate mocks

    @edwardmack
    edwardmack committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9eb8833 View commit details
    Browse the repository at this point in the history