Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/trie): Make sure writing and reading a trie to disk gives the same trie and cover more store/load child trie related test cases #2302

Merged
merged 27 commits into from
Mar 22, 2022
Merged

fix(lib/trie): Make sure writing and reading a trie to disk gives the same trie and cover more store/load child trie related test cases #2302

merged 27 commits into from
Mar 22, 2022

Commits on Feb 16, 2022

  1. Cover more store/load child trie related test cases

    @kishansagathiya
    kishansagathiya committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    47b6d27 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. test error failed to insert child trie with root in trie.Load

    @kishansagathiya
    kishansagathiya committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    29ace8a View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. temp

    @kishansagathiya
    kishansagathiya committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    772b6c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. test TestGetStorageChildAndGetStorageFromChild with non-empty trie

    @kishansagathiya
    kishansagathiya committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    061b9bf View commit details
    Browse the repository at this point in the history

  2. tackle the case when encoding and hash is same 

    i.e., encoding is less than 32 bits
    @kishansagathiya
    kishansagathiya committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    bf0f5ee View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into kishan/task/trie-test

    @kishansagathiya
    kishansagathiya committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    46af47a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. so far things work, no error finding any nodes, child tries get 

    populated

Problems that still exists:
- loaded childtries have empty bit in their encoding
- child trie leaf is being replaced by a branch
    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    8a5f18c View commit details
    Browse the repository at this point in the history

  2. child tries don't have empty bits in their encoding

    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    e4f434a View commit details
    Browse the repository at this point in the history

  3. cleaning up

    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    13f3e59 View commit details
    Browse the repository at this point in the history

  4. more clean up

    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    d6d5a87 View commit details
    Browse the repository at this point in the history

  5. accept []byte key in trie.Load instead of common.Hash

    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    4eed767 View commit details
    Browse the repository at this point in the history

  6. uncomment the test TestLoadWithChildTriesFails

    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    c24a76d View commit details
    Browse the repository at this point in the history

  7. more clean up

    @kishansagathiya
    kishansagathiya committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    d6f63bd View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. more cleanup

    @kishansagathiya
    kishansagathiya committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    46d590c View commit details
    Browse the repository at this point in the history

  2. remove mockleaf

    @kishansagathiya
    kishansagathiya committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    68e4469 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Merge branch 'development' into kishan/task/trie-test

    @kishansagathiya
    kishansagathiya committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    82db221 View commit details
    Browse the repository at this point in the history

  2. fix the commit

    @kishansagathiya
    kishansagathiya committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    42d1532 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. fix(lib/trie): Make sure writing and reading to disk gives the same t… 

    …rie (#2360)

- If a node is root, we return blake2b hash of its encoding as hash
regardless of whether length of encoding is smaller or greater than 32

- don't put childTrie again inside the trie

- Revert "accept []byte key in trie.Load instead of common.Hash"
    @kishansagathiya
    kishansagathiya authored Mar 14, 2022
    Configuration menu
    Copy the full SHA
    2dd3a2c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into kishan/task/trie-test

    @kishansagathiya
    kishansagathiya committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f174ab9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kishan/task/trie-test' of github.com:ChainSafe/gossamer… 

    … into kishan/task/trie-test
    @kishansagathiya
    kishansagathiya committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    fe91011 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. remove todos

    @kishansagathiya
    kishansagathiya committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    019953b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Update lib/trie/child_storage.go 

    Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
    @kishansagathiya @qdm12
    kishansagathiya and qdm12 authored Mar 17, 2022
    Configuration menu
    Copy the full SHA
    ccca175 View commit details
    Browse the repository at this point in the history

  2. Update dot/state/storage_test.go 

    Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
    @kishansagathiya @qdm12
    kishansagathiya and qdm12 authored Mar 17, 2022
    Configuration menu
    Copy the full SHA
    03af4b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Update dot/state/storage.go 

    Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
    @kishansagathiya @qdm12
    kishansagathiya and qdm12 authored Mar 18, 2022
    Configuration menu
    Copy the full SHA
    9d4f195 View commit details
    Browse the repository at this point in the history

  2. addressed reviews

    @kishansagathiya
    kishansagathiya committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    d6cfcc2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kishan/task/trie-test' of github.com:ChainSafe/gossamer… 

    … into kishan/task/trie-test
    @kishansagathiya
    kishansagathiya committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    31d2b8e View commit details
    Browse the repository at this point in the history

  4. renaming Test to keyValue

    @kishansagathiya
    kishansagathiya committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    5c7ec38 View commit details
    Browse the repository at this point in the history