Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin golangci-lint version to v1.43 #1979

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Nov 3, 2021

Changes

  • Update install-lint.sh to use v1.43.0
  • Pin golangci-lint workflow to use v1.43

Tests

Issues

Primary Reviewer

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1979 (0aaa3c3) into development (cd27ae4) will decrease coverage by 0.02%.
The diff coverage is 84.61%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1979      +/-   ##
===============================================
- Coverage        60.28%   60.25%   -0.03%     
===============================================
  Files              180      180              
  Lines            18198    18203       +5     
===============================================
- Hits             10971    10969       -2     
- Misses            5415     5420       +5     
- Partials          1812     1814       +2     
Flag Coverage Δ
unit-tests 60.25% <84.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/grandpa/grandpa.go 59.64% <71.42%> (+0.19%) ⬆️
cmd/gossamer/config.go 73.97% <100.00%> (-0.06%) ⬇️
cmd/gossamer/export.go 85.07% <100.00%> (+0.22%) ⬆️
dot/config.go 27.36% <100.00%> (+0.38%) ⬆️
dot/services.go 71.54% <100.00%> (+0.11%) ⬆️
dot/telemetry/telemetry.go 67.21% <0.00%> (-6.56%) ⬇️
dot/network/connmgr.go 78.76% <0.00%> (-0.89%) ⬇️
dot/core/service.go 52.91% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc89892...0aaa3c3. Read the comment docs.

@qdm12 qdm12 merged commit 90d200f into development Nov 5, 2021
@qdm12 qdm12 deleted the qdm12-pin-golangcilint branch November 5, 2021 11:15
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
* Update `install-lint.sh` to use v1.43.0
* Pin golangci-lint workflow to use v1.43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants