-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): remove dependency on scripts/ci.go
#1964
Conversation
- Remove outdated ci.go test - Build binary with `-trimpath` - Build binary without changing directory - Install binary by executing build step and moving built binary
Codecov Report
@@ Coverage Diff @@
## development #1964 +/- ##
============================================
Coverage 60.27% 60.27%
============================================
Files 180 180
Lines 18189 18189
============================================
+ Hits 10963 10964 +1
+ Misses 5415 5410 -5
- Partials 1811 1815 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
- Remove unused `scripts/ci.sh` - Dockerfile: build Go binary without `scripts/ci.go` - Build Go binary with `-trimpath` - Makefile: - remove outdated `ci.go test` from Makefile - build binary without `scripts/ci.go` - build binary without changing directory - `install` binary by executing `build` target and just `mv` the built binary
Changes
scripts/ci.sh
scripts/ci.go
-trimpath
ci.go test
from Makefilescripts/ci.go
install
binary by executingbuild
target and justmv
the built binaryTests
Whole CI passing
Issues
Related to a CI issue Omar had with
go install
vsgo build
.Primary Reviewer