Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pr-check-fix): Fix PR check (again) #1960

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Nov 2, 2021

Sorry the previous PR got merged pre-maturely 😅

Changes

  • Remove \r characters (Microsoft, really!??)
  • Display new lines as \\n in error messages so it's clearer
  • Make title regex more flexible
    • Allow - and _ in category
    • Allow -, _ and in subcategory (inside parentheses)
    • Allow at least one character to be any character at the end of the title (e.g. fullstop .)

Tests

go test -run ^Test_CheckPRDescription$ github.com/ChainSafe/gossamer/lib/utils

Issues

Primary Reviewer

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1960 (e130ce7) into development (becec9e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1960      +/-   ##
===============================================
+ Coverage        60.26%   60.28%   +0.01%     
===============================================
  Files              180      180              
  Lines            18189    18191       +2     
===============================================
+ Hits             10962    10966       +4     
+ Misses            5415     5414       -1     
+ Partials          1812     1811       -1     
Flag Coverage Δ
unit-tests 60.28% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/utils/pull_request.go 100.00% <100.00%> (ø)
dot/network/service.go 69.09% <0.00%> (-1.17%) ⬇️
lib/grandpa/grandpa.go 59.77% <0.00%> (+0.32%) ⬆️
lib/grandpa/vote_message.go 84.56% <0.00%> (+1.23%) ⬆️
lib/grandpa/message.go 65.68% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becec9e...e130ce7. Read the comment docs.

@qdm12 qdm12 changed the title chore(pr-check-fix): wip chore(pr-check-fix): Fix PR check (again) Nov 2, 2021
@qdm12 qdm12 marked this pull request as ready for review November 2, 2021 14:55
@qdm12 qdm12 merged commit 912e343 into development Nov 5, 2021
@qdm12 qdm12 deleted the qdm12-pr-check-fix branch November 5, 2021 11:14
danforbes added a commit that referenced this pull request Nov 5, 2021
danforbes added a commit that referenced this pull request Nov 5, 2021
* README for the cmd package

* Apply @qdm12 suggestions from code review

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>

* Review changes

* Review comments

* chore(ci): Fix PR check (again) (#1960)

* Standarize lists

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
* README for the cmd package

* Apply @qdm12 suggestions from code review

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>

* Review changes

* Review comments

* chore(ci): Fix PR check (again) (ChainSafe#1960)

* Standarize lists

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants