-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(codestyle): add empty code style document #1925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should put WIP
or something in the code style doc so people aren't confused that it's empty, haha
Codecov Report
@@ Coverage Diff @@
## development #1925 +/- ##
===============================================
+ Coverage 60.46% 60.49% +0.02%
===============================================
Files 185 185
Lines 18892 18892
===============================================
+ Hits 11423 11428 +5
+ Misses 5614 5612 -2
+ Partials 1855 1852 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
The idea is to subsequently do PRs to that document, discuss them on the PR to see if we all agree on a new convention. If it is agreed, we might (only then) do code changes to make the code conform to it as part of this PR.
Tests
Issues
Primary Reviewer