Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(codestyle): add empty code style document #1925

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Oct 25, 2021

Changes

  • Add empty code style document
  • Reference it in readme
  • Reference it in contributing document

The idea is to subsequently do PRs to that document, discuss them on the PR to see if we all agree on a new convention. If it is agreed, we might (only then) do code changes to make the code conform to it as part of this PR.

Tests

  • No test

Issues

  • No issue

Primary Reviewer

  • Anyone, no hurry.

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should put WIP or something in the code style doc so people aren't confused that it's empty, haha

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1925 (558c318) into development (d71b524) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1925      +/-   ##
===============================================
+ Coverage        60.46%   60.49%   +0.02%     
===============================================
  Files              185      185              
  Lines            18892    18892              
===============================================
+ Hits             11423    11428       +5     
+ Misses            5614     5612       -2     
+ Partials          1855     1852       -3     
Flag Coverage Δ
unit-tests 60.49% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/runtime/life/resolver.go 60.69% <ø> (ø)
dot/network/connmgr.go 78.76% <0.00%> (-0.89%) ⬇️
lib/babe/babe.go 51.04% <0.00%> (ø)
dot/network/service.go 70.43% <0.00%> (+1.15%) ⬆️
lib/babe/epoch.go 66.66% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed507d2...558c318. Read the comment docs.

@noot noot merged commit 855e25e into development Oct 27, 2021
@noot noot deleted the qdm12-codestyle-doc branch October 27, 2021 20:56
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants