Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Integrate scale package into lib/trie #1804

Merged
merged 3 commits into from
Sep 28, 2021
Merged

chore: Integrate scale package into lib/trie #1804

merged 3 commits into from
Sep 28, 2021

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Sep 23, 2021

Changes

  • Revise lib/trie/Hasher to become private
  • Update scale integration in lib/trie/hash.go

Tests

go test ./lib/trie

Issues

Primary Reviewer

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1804 (576efeb) into development (9b2f41e) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1804      +/-   ##
===============================================
- Coverage        59.57%   59.51%   -0.07%     
===============================================
  Files              187      186       -1     
  Lines            19782    19724      -58     
===============================================
- Hits             11785    11738      -47     
+ Misses            5983     5982       -1     
+ Partials          2014     2004      -10     
Flag Coverage Δ
unit-tests 59.51% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/trie/hash.go 77.17% <100.00%> (-0.96%) ⬇️
lib/trie/node.go 78.63% <100.00%> (ø)
lib/trie/print.go 70.96% <100.00%> (ø)
lib/trie/trie.go 92.66% <100.00%> (ø)
dot/state/block_notify.go 75.30% <0.00%> (-9.88%) ⬇️
dot/network/test_helpers.go 78.78% <0.00%> (-4.05%) ⬇️
lib/babe/epoch.go 64.51% <0.00%> (-2.16%) ⬇️
lib/blocktree/blocktree.go 55.61% <0.00%> (-1.13%) ⬇️
dot/network/sync.go 64.22% <0.00%> (-0.40%) ⬇️
lib/babe/babe.go 57.41% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b2f41e...576efeb. Read the comment docs.

@timwu20 timwu20 force-pushed the tim-1750 branch 2 times, most recently from 3c60752 to 3b4fb18 Compare September 23, 2021 17:07
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, lgtm.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 added a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
* remove unused Encode/Decode

* update scale integration

* newHasher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants