feat: add JSON-RPC benchmarks with k6
#5438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
force-pushed
the
rpc-benchmarks
branch
from
65c7e4c to
3564495
Compare
LesnyRumcajs
requested review from
elmattic and
lemmih
and removed request for
a team
hanabi1224
reviewed
Mar 24, 2025
hanabi1224
reviewed
Mar 24, 2025
| @@ -0,0 +1,13 @@ | |||
| all-forest-cloud: | |||
Contributor
There was a problem hiding this comment.
These commands could go into package.json. It's rare to use makefile in js world.
Member
Author
There was a problem hiding this comment.
I wouldn't say we are precisely in the JS world. k6 itself is a Go app that happens to use JS for its test scenarios.
hanabi1224
reviewed
Mar 24, 2025
|
|
||
| | Name | Description | Type | Default | | ||
| | --------------- | --------------------------- | ---- | ------------------------------ | | ||
| | `K6_TEST_URL` | Node RPC endpoint | URL | `http://localhost:2345/rpc/v1` | |
Contributor
There was a problem hiding this comment.
How about prefixing environment variables with FOREST_RPC_
Member
Author
There was a problem hiding this comment.
A strong no. These benchmarks should be client-agnostic.
hanabi1224
approved these changes
Mar 24, 2025
Contributor
hanabi1224
left a comment
hanabi1224
left a comment
There was a problem hiding this comment.
It'd be great to use typescript. I can do that afterwards.
Co-authored-by: hanabi1224 <harlowmoo@gmail.com>
LesnyRumcajs
force-pushed
the
rpc-benchmarks
branch
from
a7de567 to
256203f
Compare
lemmih
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
k6Reference issue to close (if applicable)
Closes #5389
Other information and links
Change checklist