chore: Upgrade libp2p and bitswap #2154
Conversation
hanabi1224
force-pushed
the
upgrade-libp2p
branch
9 times, most recently
from
46fee9e
to
0fa8772
Compare
hanabi1224
force-pushed
the
upgrade-libp2p
branch
from
0fa8772
to
15cda39
Compare
hanabi1224
force-pushed
the
upgrade-libp2p
branch
from
a3620db
to
fa66fa1
Compare
hanabi1224
force-pushed
the
upgrade-libp2p
branch
from
ae20d1b
to
29f30a2
Compare
hanabi1224
force-pushed
the
upgrade-libp2p
branch
from
d8cc734
to
8224ed9
Compare
hanabi1224
requested review from
elmattic,
lemmih,
LesnyRumcajs and
jdjaustin
as code owners
|
This branch work for connecting to calibnet but I'm having difficulties with mainnet. Seeing a lot of this error:
|
|
Hmm, the DO droplet is too slow to match up to the most recent tipset. But it hasn't failed so far. Just a lots of notices that seem to be harmless. |
|
@hanabi1224 Can we do something about the error messages and warnings? I see lots of these for every validated tipset:
|
Sure, let me confirm the error message does not mean Update: |
|
I'm completely synced to mainnet and everything appears to be in order! Nice! |
| self.put_keyed(block.cid(), block.data()) | ||
| } | ||
|
|
||
| fn missing_blocks(&mut self, cid: &Cid) -> anyhow::Result<Vec<Cid>> { |
There was a problem hiding this comment.
Can we extract this method? Seems it will be exactly the same for all structs implementing Store.
There was a problem hiding this comment.
Good suggestion, fixed
| } | ||
|
|
||
| #[allow(clippy::too_many_arguments)] | ||
| async fn handle_forest_behaviour_event<DB, P: StoreParams>( |
There was a problem hiding this comment.
It would be nice to refactor such oversized methods so there's a single match calling methods. 300 LoC for a method isn't ideal.
There was a problem hiding this comment.
I have created #2220 to track this refactoring
Summary of changes
Changes introduced in this pull request:
libp2pto0.49.0libp2p-bitswapto0.24bitswaplogicprotocin CI env andDockerfilewhich is required bylibp2p 0.47+It reduces build time by not buildingprotocfrom source)tiny-cidManual test on calibnetcalibnet sync checkCI job passesReference issue to close (if applicable)
Closes #1924 #1920
Other information and links