-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiaddr to ENR #142
Add multiaddr to ENR #142
Conversation
This can be dropped later.
This was meant for my own fork |
Feel free to do a PR upstream if you feel a feature is missing! |
hi There, Few comments and I am not sure at this stage what is the most straightforward way.
For simplicity sake, I decided to import the code in js-waku: waku-org/js-waku#324 To not depend on several crypto library, I also swapped bcrypto for secp256k1. Now, I intend at some point to extract the ENR code and the EIP-1459 code as their own package so other projects can use it. I will also need to implement discv5 as well, but it needs to use the ENR with Having said that, I am keen to collaborate if you think the core change I implemented ( |
@wemeetagain I'm sure we can extend enr + discv5 to support this changes! |
Hey @D4nte Also we'd love to split out the ENR logic into a separate package. |
Thank you both for your comments. What are your thoughts in regards of the cryptography backend? Bcrypto vs secpk1? Was bcrypto chosen because it supports various curves, even though only secpk1 is used for ENRs? I believe both our project target browser environment so limiting dependencies is always preferred. Ps: I am in leave at the moment so apologies if I take time to reply/action. |
I think bcrypto was used because it was already being used for discv5 crypto. |
No description provided.