Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Conversation

@nmlinaric
Copy link
Contributor

Description

  • extend GenericHandler with IDepositExecute
  • remove revert on fail for GenericHandler

Related Issue Or Context

Closes: #565

How Has This Been Tested? Testing details.

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

@lastperson lastperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indents need to be fixed.

@nmlinaric nmlinaric merged commit 3bcbce5 into master Jun 21, 2022
@nmlinaric nmlinaric deleted the nmlinaric/generic-handler branch June 21, 2022 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement IDepositExecute on GenericHandler

4 participants