Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Conversation

@nmlinaric
Copy link
Contributor

Description

Function that emits Retry event which triggers the retry failed deposit process on the MPC side.

Related Issue Or Context

Closes: #542

How Has This Been Tested? Testing details.

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric changed the title Add retry functions Add retry function Jun 8, 2022
P1sar
P1sar previously approved these changes Jun 9, 2022
Copy link
Contributor

@P1sar P1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I have a question, for example we are going to have 10 networks. User submits this hash on the source chain, relayers would need to search all 10 networks to found where this execution failed. So maybe we should also add dst network ID or something like that? @mpetrun5 @nmlinaric

@P1sar P1sar dismissed their stale review June 9, 2022 15:01

I have new question

@mpetrun5
Copy link
Member

mpetrun5 commented Jun 9, 2022

Btw I have a question, for example we are going to have 10 networks. User submits this hash on the source chain, relayers would need to search all 10 networks to found where this execution failed. So maybe we should also add dst network ID or something like that?

We will find all data from initial Deposit event related to that transaction hash (which is of a deposit event).

@P1sar
Copy link
Contributor

P1sar commented Jun 9, 2022

Oh yes for sure

@nmlinaric nmlinaric merged commit b5c335f into master Jun 20, 2022
@nmlinaric nmlinaric deleted the nmlinaric/retry-func branch June 20, 2022 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add function for retrying deposits

5 participants