Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Develop #413

Merged
merged 7 commits into from
Oct 27, 2021
Merged

Develop #413

merged 7 commits into from
Oct 27, 2021

Conversation

P1sar
Copy link
Member

@P1sar P1sar commented Oct 27, 2021

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

andersonlee725 and others added 7 commits September 9, 2021 00:48
* remove DepositRecord in every handler,  modify event in Bridge, modify IDepositExecute interface
* modify test files based on removing deposit records
* add handlerResponse to deposit event and modify test files based on the event
Set disableConfirmationListener: true to avoid spamming ganache during tests. trufflesuite/truffle#3522
@P1sar P1sar merged commit cbfaf9c into master Oct 27, 2021
@P1sar P1sar deleted the develop branch October 27, 2021 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants