fix(asset-index): use transfer instead of deposit for liquid assets#420
Merged
fix(asset-index): use transfer instead of deposit for liquid assets#420
Conversation
mattsse
added
break-api
clearloop
suggested changes
Sep 28, 2021
clearloop
added
needs changes
Contributor
|
plz fix the benchmarks |
Contributor
|
Still broken in the benchmarks, I can join to debug this later |
Contributor
Author
ah I know what's up, fixing this rn |
clearloop
added
needs review
clearloop
approved these changes
Oct 2, 2021
mattsse
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Failing tests are updated to allocate some funds for
add_assetDid not check the JS test suite however.
Issues