Skip to content

Conversation

@mattsse
Copy link
Contributor

@mattsse mattsse commented Aug 31, 2021

Changes

This is intended to be the submodule branch for the Mandala integration

  • Remove all unnecessary stuff

@clearloop should we keep the CI stuff probably yes, right?

Tests


Issues

@clearloop
Copy link
Contributor

I think we don't have to clean our repo only for the branch of the Acala integration, if the target branch has too much different from our main branch, the updates will be a problem, what about a specific runtime inside the main branch?

polkadot has a lot of branches because it's really big

@mattsse
Copy link
Contributor Author

mattsse commented Aug 31, 2021

I think we don't have to clean our repo only for the branch of the Acala integration, if the target branch has too much different from our main branch, the updates will be a problem, what about a specific runtime inside the main branch?

polkadot has a lot of branches because it's really big

We only need the pallets and primitives for acala integration, we can only merge those folders, which should be easy with git fetch && git checkout HEAD pallets or something.
What we need to modify is at least the Cargo.toml because this nested workspace will throw an error when used as submodule so we need to get rid of this.

So you're suggesting only removing th Cargo.toml file?
I had a look at the other ecosystem modules and they are pretty much cleaned up. so I did the same.

@clearloop
Copy link
Contributor

We only need the pallets and primitives for acala integration, we can only merge those folders, which should be easy with git fetch && git checkout HEAD pallets or something.
What we need to modify is at least the Cargo.toml because this nested workspace will throw an error when used as submodule so we need to get rid of this.

So you're suggesting only removing th Cargo.toml file?
I had a look at the other ecosystem modules and they are pretty much cleaned up. so I did the same.

Clean it up is also okay, the only thing I'm considering is about the problem of updating the branch, what about the acala guys writing scripts to modify the workspace section in our Cargo.toml =.=

@mattsse
Copy link
Contributor Author

mattsse commented Aug 31, 2021

We only need the pallets and primitives for acala integration, we can only merge those folders, which should be easy with git fetch && git checkout HEAD pallets or something.
What we need to modify is at least the Cargo.toml because this nested workspace will throw an error when used as submodule so we need to get rid of this.
So you're suggesting only removing the Cargo.toml file?
I had a look at the other ecosystem modules and they are pretty much cleaned up. so I did the same.

Clean it up is also okay, the only thing I'm considering is about the problem of updating the branch, what about the acala guys writing scripts to modify the workspace section in our Cargo.toml =.=

There won't be a workspace Cargo.toml, because cargo does not support nested workspaces therefore we only keep the pallets' Cargo.toml file.
But perhaps we could exclude the whole pint subdirectory instead, let me try that first.

@mattsse
Copy link
Contributor Author

mattsse commented Aug 31, 2021

you were right, excluding the pint workspace was way easier than modifying the whole workspace
we should propably fix #310 on main first before including this.

@mattsse mattsse added WIP Work in progress - do not review or merge and removed needs review PR needs reviewing labels Aug 31, 2021
@clearloop
Copy link
Contributor

@mattsse can you merge main and check if clippy is happy?

@mattsse
Copy link
Contributor Author

mattsse commented Sep 9, 2021

closing this since we do not need to make any changes anymore. instead we can branch off main directly.

@mattsse mattsse closed this Sep 9, 2021
@clearloop clearloop deleted the matt/ecosystem-acala branch December 7, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in progress - do not review or merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants