-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add Acala compatible workspace #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0da4e6b to
5fc7cd0
Compare
|
I think we don't have to clean our repo only for the branch of the Acala integration, if the target branch has too much different from our main branch, the updates will be a problem, what about a specific runtime inside the main branch? polkadot has a lot of branches because it's really big |
We only need the pallets and primitives for acala integration, we can only merge those folders, which should be easy with git fetch && git checkout HEAD pallets or something. So you're suggesting only removing th |
Clean it up is also okay, the only thing I'm considering is about the problem of updating the branch, what about the acala guys writing scripts to modify the workspace section in our |
There won't be a workspace Cargo.toml, because cargo does not support nested workspaces therefore we only keep the pallets' Cargo.toml file. |
This reverts commit 930178a.
|
you were right, |
|
@mattsse can you merge main and check if clippy is happy? |
|
closing this since we do not need to make any changes anymore. instead we can branch off main directly. |
Changes
This is intended to be the submodule branch for the Mandala integration
@clearloop should we keep the CI stuff probably yes, right?
Tests
Issues