-
Notifications
You must be signed in to change notification settings - Fork 9
feat(asset-index): add AssetMetadata #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is one not clear for me, Assets can be submitted by different accounts, but are always unique.
This is a very good point. Yes unique int ids make the most sense, I guess the What we certainly need is some kind of additional metadata struct for every asset, something like similar to chainlink feed info I don't think we have a proper storage map for this, we have the |
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping Metadata separate will be more convenient
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
After thinking about it over again, I don't think refactoring
AssetIdtoenumis a better idea, the following is whatAssetIdis in my current understandingenum, theenumhave to wrap something which can make Assets different from others, and the easiest and the most practical type isnumbernumberChanges
AssetId: + AtLeast32BitUnsignedTests
Issues
Closes #102
Closes #115