This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Increase maxPriorityFeePerGas on capped gas price #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardolyn
reviewed
Sep 1, 2021
| @@ -170,7 +170,7 @@ func (c *Connection) EstimateGasLondon(ctx context.Context, baseFee *big.Int) (* | |||
| var maxFeePerGas *big.Int | |||
|
|
|||
| if c.maxGasPrice.Cmp(baseFee) < 0 { | |||
| maxPriorityFeePerGas = big.NewInt(1) | |||
| maxPriorityFeePerGas = big.NewInt(1000000000) | |||
There was a problem hiding this comment.
can we make this configurable and by default 1000000000?
There was a problem hiding this comment.
its possible and we will but for now its a quick fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the issue referenced below, miners do not pick up transactions greater that have been capped by
maxGasPriceas they are sent with amaxPriorityFeePerGasof 1 wei. This PR makes themaxPriorityFeePerGas1 gwei (could be raised) to make sure the tx is actually picked up by miners.The issue poster suggested always using the suggested market price for
maxPriorityFeePerGas, as a tx can never be greater thanmaxFeePerGas. However, this could potentially lead to prices much higher than specified as themaxPriorityFeePerGaswould not be included in the total gas price cap.Related Issue Or Context
Closes: #704
How Has This Been Tested? Testing details.
Types of changes
Checklist: