-
Notifications
You must be signed in to change notification settings - Fork 217
Update docs CAIP-350 #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update docs CAIP-350 #395
Conversation
This reverts commit 084ba91.
| - [ERC-7930]'s Interoperable Address and [ERC-7930]'s Interoperable Name of the ecosystem's chain references | ||
| - [ERC-7930]'s Interoperable Address and [ERC-7930]'s Interoperable Name of the ecosystem's addresses *for all address formats of said ecosystem* | ||
| Chain References: | ||
| - **customary text ↔ standard text**: Between customary chain reference text formats of the ecosystem (which may also be described in [CAIP-2]) and a standard text representation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of confusing because [CAIP-2] profiles per namespace already unambiguously convert between customary text and [a slightly different, in some cases] standard text... I think it would help to better explain that the "standard text" here is a slight variant of CAIP-2 that is identical for many namespaces but for others less lossy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new section titled “CAIP-2/CAIP-10 Compatibility.”
bumblefudge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than making more explicit the relationship between CAIP-2 and CAIP-350 in the ## Specification section, I think the changes are an improvement on the existing text and seem R2G
CAIP-350 has been updated based on the feedback
| #### CAIP-2/CAIP-10 Compatibility | ||
| The "standard text" in CAIP-350 profiles is a variant of [CAIP-2]/[CAIP-10] that is identical for most namespaces, but less lossy for those where length restrictions cause truncation (e.g., Solana's genesis blockhash). | ||
|
|
||
| Each CAIP-350 profile MUST state whether its standard text differs from [CAIP-2]/[CAIP-10], and how. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice good thinking
bumblefudge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
This update includes two main changes:
<namespace>:<chainReference>. This improves clarity and ensures consistency across all namespace profiles, where each profile now defines only the<chainReference>portion.