Support underscores in chain ID reference #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you also add a PR to add starknet to the namespaces repo? |
Contributor
Author
Will do the PR. Drafting this one for now as there may be better ways of representing StarkNet chain ids that don't require this change. |
Collaborator
|
@pedrouid any reason not to add support for |
Contributor
Author
|
@oed @pedrouid here is PR for |
bumblefudge
approved these changes
Dec 2, 2022
Collaborator
|
@delaaxe this LGTM but maybe we can get the namespace finalized by thursday the 15th so that we don't have an example in a CAIP that isn't backed up by a namespace entry? I'm applying 14-day merge tag so that this breaking change gets triaged in the same bump to the last breaking change to this CAIP. |
bumblefudge
added
the
14-day merge
ntn-x2
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 22, 2023
Fixes https://github.com/KILTprotocol/ticket/issues/2458. - CAIP-19 asset reference max length was increased to 128: ChainAgnostic/CAIPs#179 - CAIP-2 chain reference now supports underscores: ChainAgnostic/CAIPs#180 - CAIP-19 asset reference and asset identifier now support `.` and `%` symbols: ChainAgnostic/CAIPs#160 Not a breaking change since it just relaxes some requirements.
webguru9178
pushed a commit
to webguru9178/kilt-node
that referenced
this pull request
Jan 8, 2024
Fixes https://github.com/KILTprotocol/ticket/issues/2458. - CAIP-19 asset reference max length was increased to 128: ChainAgnostic/CAIPs#179 - CAIP-2 chain reference now supports underscores: ChainAgnostic/CAIPs#180 - CAIP-19 asset reference and asset identifier now support `.` and `%` symbols: ChainAgnostic/CAIPs#160 Not a breaking change since it just relaxes some requirements.
hacker-nova7431
added a commit
to hacker-nova7431/kilt-node
that referenced
this pull request
Sep 29, 2025
Fixes https://github.com/KILTprotocol/ticket/issues/2458. - CAIP-19 asset reference max length was increased to 128: ChainAgnostic/CAIPs#179 - CAIP-2 chain reference now supports underscores: ChainAgnostic/CAIPs#180 - CAIP-19 asset reference and asset identifier now support `.` and `%` symbols: ChainAgnostic/CAIPs#160 Not a breaking change since it just relaxes some requirements.
infra-riderju74
added a commit
to infra-riderju74/kilt-node
that referenced
this pull request
Oct 27, 2025
Fixes https://github.com/KILTprotocol/ticket/issues/2458. - CAIP-19 asset reference max length was increased to 128: ChainAgnostic/CAIPs#179 - CAIP-2 chain reference now supports underscores: ChainAgnostic/CAIPs#180 - CAIP-19 asset reference and asset identifier now support `.` and `%` symbols: ChainAgnostic/CAIPs#160 Not a breaking change since it just relaxes some requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for underscores in the chain id reference allows using StarkNet chain ids as-is (
SN_MAIN,SN_GOERLI) without having to do error-prone translations in both dapps and wallets.Such a change shouldn't impact the existing requirements for the reference.