Write gltf changes #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ function updateBinaryObject(gltf, pipelineExtras, name, state) { | |||
| state.currentBinaryView++; | |||
| } | |||
|
|
|||
| var objectSource = object.extras._pipeline.source; | |||
| var objectSource = new Buffer(object.extras._pipeline.source); | |||
There was a problem hiding this comment.
Buffer.concat below didn't like concatting a shader string with a buffer, so I just always wrap the source in a Buffer.
| } | ||
| mkdirp.sync(path.dirname(outputPath)); |
There was a problem hiding this comment.
This change includes all the deleted specs. I thought it was weird that the pipeline won't export a gltf file unless createDirectory is true, especially since there are cases where you don't want the file to be put in an output folder.
|
@lasalvavida do you want to review this? |
|
These changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few random fixes and changes related to writing gltfs.