Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to eslint-cesium-config/node v9.0.0 #617

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Upgrades to eslint-cesium-config/node v9.0.0 #617

merged 5 commits into from
Jul 13, 2022

Conversation

sanjeetsuhag
Copy link
Contributor

@sanjeetsuhag sanjeetsuhag commented Jul 6, 2022 •
edited
Loading

  • Updates to eslint-cesium-config/node version 9.0.0
  • Upgrades to Node 16.0.0

@sanjeetsuhag sanjeetsuhag marked this pull request as ready for review July 11, 2022 18:15
@sanjeetsuhag sanjeetsuhag requested a review from ggetz July 11, 2022 18:15
@ggetz
Copy link
Contributor

ggetz commented Jul 11, 2022

Thanks @sanjeetsuhag! Would you or @lilleyse be able to recommend a testing plan?

@lilleyse
Copy link
Contributor

If the unit tests pass that should be good enough, though it doesn't hurt to run the CLI as well:

./bin/gltf-pipeline.js -i specs/data/2.0/box-textured-embedded/box-textured-embedded.gltf -o box.glb

@ggetz
Copy link
Contributor

ggetz commented Jul 13, 2022

Looks great to me! Thanks @sanjeetsuhag and @lilleyse!

@ggetz ggetz merged commit c4b990d into main Jul 13, 2022
@ggetz ggetz deleted the eslint-update branch July 13, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggetz ggetz Awaiting requested review from ggetz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanjeetsuhag @ggetz @lilleyse