Case-insensitive regexes for checking image extensions #270 #278
Conversation
|
Fixes #270 |
lib/loadGltfUris.js
Outdated
| @@ -169,7 +168,7 @@ var jimpSupportedExtensions = ['.png', '.jpg', '.jpeg', '.bmp']; | |||
| function generateJimpImage(object) { | |||
| var pipelineExtras = object.extras._pipeline; | |||
| var ext = pipelineExtras.extension; | |||
| if (jimpSupportedExtensions.indexOf(ext) === -1) { | |||
| if (supportedExtensions.test(ext)) { | |||
There was a problem hiding this comment.
This should be !supportedExtensions.test(ext)
There was a problem hiding this comment.
Looks like me and @mramato replied at about the same time.
There was a problem hiding this comment.
@mramato @lilleyse Silly mistake sorry . I appreciate the patience with me muddling my way through this first attempt at GitHub and my first attempt at contributing to a "real" project. I hope I haven't been to much of a disturbance in the operation of things for everyone. Thank you for allowing me to participate.
There was a problem hiding this comment.
Don't be so hard on yourself. We are were all first time committers at some point. We are happy to help and appreciate your help.
|
Thanks @ryki2658, the tests are failing because you reversed the if check. Previously it was checking if the extension was not in the list, now it's checking if it is in the list. You need to add a |
|
Thanks again, @ryki2658. |
|
No problem happy to be involved! |
…image extensions