Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to set bottomContainer will not be created by default. #9742

Closed
wants to merge 4 commits into from
Closed

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Aug 21, 2021

Cesium.Viewer.ConstructorOptions:

  1. Add a bottomContainer option
  2. If set to false, the bottomContainer will not be created.

If you don't want to display bottomContainer or CreditDisplay, you can set it like this:

const viewer = new Cesium.Viewer('cesiumContainer', {
    bottomContainer: false
})

I think it will be very convenient.

@cesium-concierge
Copy link

Thank you so much for the pull request @puxiao! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Aug 21, 2021

Thanks for the pull request @puxiao. However, you should not be removing the CreditDisplay from the viewer. Many data providers, including Cesium ion, have attribution requirements for using their data in applications, so hiding this would be a violation of their terms of service.

@hpinkos hpinkos closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants