Fix the issue where camera zoom get stuck when looking up #9126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the camera zooming is stuck when looking up to the target. It is because the math for zooming assumes the camera is always looking down to the earth surface. The fix is to check the angle between the camera direction and the earth-origin-to-camera direction. If they are less than 120 degree, it looks up and we choose the method zoom-on-vector. Theoretically, we should check for 90 degree, but in practice, it doesn't work really well.
@lilleyse Can you please take a look at it? Please let me know if I should add anything