-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dayAlpha and nightAlpha in the ImageryLayer #8868
Conversation
Thanks for the pull request @epranka!
Reviewers, don't forget to make sure that:
|
Thanks for the pull request @epranka! This is a really cool feature. @lilleyse or @IanLilleyT would you be able to take a look at this? |
Thanks for the feature @epranka! I just reviewed it and the only major change I made was moving this behavior to the Earth at Night sandcastle instead of its own. Toggle If anyone else wants to take a quick look at this before the month is over, please do! This should be able to fit in the June release if all goes well. |
Looks good to me! @IanLilleyT do you want to merge this? |
Yesterday I created this pull request: #8862. But I closed it because, after some tests, I found that it has a big issue than using the multi-layers setup. Sorry for that, I had to test more before opening the pull request.
But today I create it again with improvement. I added the two options to
ImageryLayer
:dayAlpha
: The alpha blending value of this layer on the day side of the globe.nightAlpha
: The alpha blending value of this layer on the night side of the globe.This only takes effect when
enableLighting
istrue
The main reason to do this was to have day and night Earth textures depending on the lighting as an example below.
Also, I created the showcase of it called Night textures on the shade side in the Sandcastle.
Sample usage code (from showcase):