Fixed crash when creating plane with translation and normal on the Z axis #8576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sandcastle with crash
Sandcastle with fix
When creating the model matrix the code tries to generate an up vector that is different than the normal, and does this by setting the up vector to
UNIT_Z
. But if the normal itself isUNIT_Z
, the problem is still there. So I added another check that sets it toUNIT_X
if setting toUNIT_Z
failed.