Make CartesianX.packArray() compatible with typed arrays #8568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
CartesianX.packArray()
cannot be used on a typed array because it attempts to setarray.length
. This property is read-only for typed arrays likeFloat64Array
This PR fixes this for all three types of Cartesian vectors. It also updates the packing unit tests to make sure all three classes have the same set of packing tests.
Sandcastle example (Cartesian3 only)