Make primitives/entities not cull when below ellipsoid but above terrain #8398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current system culls entities/primitives when they are below the minimum radius of the earth, ~6356752 meters. In practice there are not many points on earth that are below this, except maybe https://en.wikipedia.org/wiki/Bentley_Subglacial_Trench which cesium world terrain doesn't accurately map. But with terrain exaggeration enabled or some other configuration, this becomes a problem. The proposed fix is to keep track of the minimum rendered terrain tile height and offset the scene's occluder radius by it. This information could also assist in choosing a better distance for the depth plane: #8203.
In this Sandcastle, left click to spawn red dots. In master, the dots do not appear. In this PR, they do.
This is a draft PR because there are a few unknowns: