Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GEE terrain negative altitude handling #8109

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Fix GEE terrain negative altitude handling #8109

merged 2 commits into from
Sep 3, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Aug 26, 2019

  1. We were multiplying height by the negativeAltitudeExponentBias directly instead of -2^negativeAltitudeExponentBias which is correct in the comments, but not in the code.

  2. The conversion from earth radius to meters needs to happen after the negative altitude bias is applied, otherwise the value would be incorrect.

1. We were multiplying height by the `negativeAltitudeExponentBias` directly
instead of `-2^negativeAltitudeExponentBias` which is correct in the
comments, but not in the code.

2. The conversion from earth radius to meters needs to happen after the
negative altitude bias is applied, otherwise the value would be incorrect.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor Author

mramato commented Aug 26, 2019

@tfili this needs to go out with the next release, but that's also your first day back in the office so you can just wait until that morning if you want. This is low impact outside of GEE.

@tfili tfili merged commit 002d4f0 into master Sep 3, 2019
@tfili tfili deleted the gee-heights branch September 3, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants