New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing info in CHANGES #7973

Merged

tfili merged 1 commit into master from fix-changes

Jun 30, 2019

Contributor

OmarShehata commented Jun 29, 2019

Needed to correct the CHANGES from the MapBox styles PR (see #7698 (comment)). Also I noticed two additions were missing links to the PR.


          Missing info in CHANGES

888913d

cesium-concierge commented Jun 29, 2019

Thanks for the pull request @OmarShehata!

✔️ Signed CLA found.
❔ Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

OmarShehata mentioned this pull request

Create new imagery provider for MapBox styles #7698

Merged

tfili merged commit a84de91 into master

tfili deleted the fix-changes branch

June 30, 2019 23:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet